Enable automatic underscore replace for primary-bundle-id

munki · Jun 17, 2019 · 81fec0e · gregneagle · Jun 17, 2019 · MichalMMac
1 parent 5af2ae3
commit 81fec0e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -272,7 +272,7 @@ Keys/values of the `notarization_info` dictionary:
 | username          | String  | Yes      | Login email adress of your developer Apple ID |
 | password          | String  | Yes      | 2FA app specific password. For information about the password and saving it to the login keychain see the web page [Customizing the Notarization Workflow](https://developer.apple.com/documentation/security/notarizing_your_app_before_distribution/customizing_the_notarization_workflow) |
 | asc_provider      | String  | No       | Only needed when a user account is associated with multiple providers |
-| primary_bundle_id | String  | No       | Defaults to `identifier`. `primary_bundle_id` is useful when `identifier` contains characters such as '_' Apple notary service does not like |
+| primary_bundle_id | String  | No       | Defaults to `identifier`. Whether specified or not underscore characters are always automatically converted to hyphens since Apple notary service does not like underscores |
 | staple_timeout    | Integer | No       | See paragraph bellow |
 
 **About accessing password in keychain**

diff --git a/munkipkg b/munkipkg
@@ -675,7 +675,7 @@ def upload_to_notary(build_info, options):
         '--primary-bundle-id',
         build_info['notarization_info'].get(
             'primary_bundle_id', build_info['identifier']
-        ),
+        ).replace('_', '-'),
         '--username',
         build_info['notarization_info']['username'],
         '--password',