Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

err not defined in scope #40

Closed
MichalMMac opened this issue Jun 6, 2019 · 3 comments
Closed

err not defined in scope #40

MichalMMac opened this issue Jun 6, 2019 · 3 comments

Comments

@MichalMMac
Copy link
Contributor

Discovered by flake8 formatter: undefined name 'err'

munki-pkg/munkipkg

Line 178 in 30f4373

% (returncode, " ".join(str(err).split())))

IMHO err is only defined withing previous except block.
@MichalMMac MichalMMac mentioned this issue Jun 6, 2019
Closed
@gregneagle
Copy link
Contributor

Interesting that pylint missed this!

@gregneagle
Copy link
Contributor

I don't remember when this got addressed, but the issue isn't present in the current code as far as I can see. Closing.

@MichalMMac
Copy link
Contributor Author

git blame shows It got fixed in the commit c3b3c04

Great! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregneagle @MichalMMac