Apply black and isort formatteres #39
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
I'm not yet ready to commit to consistently using those tools with my projects. If I merged this today, it would probably drift away from that style. Should definitely fix the undefined variable "err" bit, though. |
|
I am going to close this and change formatting of #42 to match the original style. OK? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we started using
black,flake8andisortinautopkgI run them on munkipkg and submitted this PR if you are interested.Flake8 notes:
ndefined name 'basestring': PR Replace basestring with string_types #41undefined name 'err': Issue err not defined in scope #40