Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logic error when processing requires items that fail to download #1188

Closed
gregneagle opened this issue Oct 25, 2023 · 2 comments
Closed

Logic error when processing requires items that fail to download #1188

gregneagle opened this issue Oct 25, 2023 · 2 comments

Comments

@gregneagle
Copy link
Contributor

gregneagle commented Oct 25, 2023 •
edited

When processing managed_installs items, if an item has a "requires" list and one of the required items was processed earlier, but failed to download, it is erroneously considered available, and the dependent item can be marked as installable even though the dependency is not actually available.

The issue is here: https://github.com/munki/munki/blob/main/code/client/munkilib/updatecheck/analyze.py#L342-L347

item_in_installinfo will return True even for items that failed to download.

See also discussion in MacAdmins Slack: https://macadmins.slack.com/archives/C04QVPFGU/p1698251171599269
@gregneagle
Copy link
Contributor Author

Looks like this might be the same issue as #1104

gregneagle added a commit that referenced this issue Nov 20, 2023
@gregneagle
Address #1188 and #1104. Better handling of dependencies/requirements…
9ba39af 
… when a required item fails to download, but is also required by other items.
@gregneagle
Copy link
Contributor Author

Addressed here: 9ba39af

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gregneagle