Hide non-updates labels in sidebar when not applicable #1089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amends MSC to only show the updates view if no optional installs are declared, mimicking prior MSC's behaviour
gregneagle
changed the title
gregneagle
reviewed
May 11, 2021
.../apps/Managed Software Center/Managed Software Center/Controllers/MainWindowController.swift
Outdated
Show resolved
Hide resolved
|
Thank you for this change !!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on munki-dev
This PR amends MSC to only show the updates view if no optional installs are declared, mimicking prior MSC's behaviour.
Prior to this PR, MSC would look like the below if no optional installs are declared:
Post this PR:
If/when merged and released, I'll update: https://github.com/munki/munki/wiki/FAQ#q--i-just-set-up-munki-and-theres-nothing-available-under-software-or-categories-and-the-icons-are-greyed-out-how-do-i-make-things-available-there