Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standard MIDI file player may fail to send all-sound-off when stopping playback #80

Closed
sergm opened this issue Dec 19, 2021 · 0 comments
Closed

Standard MIDI file player may fail to send all-sound-off when stopping playback #80

sergm opened this issue Dec 19, 2021 · 0 comments
Assignees
@sergm
Labels
Bug mt32emu-qt
Milestone
mt32emu_qt_1_10

Comments

@sergm
Copy link
Member

sergm commented Dec 19, 2021

Apparently, the SMF player fails to flush the queued MIDI messages before sending the all-sound-off sequence when being stopped and the corresponding SynthRoute is not in the multi-session mode. This bug was introduced since mt32emu-qt 1.8.0.
@sergm sergm added this to the mt32emu_qt_1_10 milestone Dec 19, 2021
@sergm sergm self-assigned this Dec 19, 2021
sergm added a commit that referenced this issue Dec 19, 2021
@sergm
Fixed SMF player not sending all-sound-off sequence when stopped (#80)
a863dd5
@sergm sergm closed this as completed Dec 19, 2021
sergm added a commit that referenced this issue Jan 13, 2022
@sergm
Ensured that all MIDI events played via SMF player get processed (#80)
af501b1 
Previously, some events may be occasionally dropped from the queue before
sending the terminal all-sound-off sequence.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergm sergm

Labels
Bug mt32emu-qt
Projects
None yet
Milestone
mt32emu_qt_1_10
Development

No branches or pull requests
1 participant
@sergm