Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Dark theme #93

Open
ParticleMon opened this issue Jun 3, 2022 · 8 comments
Open

[Enhancement] Dark theme #93

ParticleMon opened this issue Jun 3, 2022 · 8 comments

Comments

@ParticleMon
Copy link

ParticleMon commented Jun 3, 2022

The floating LCD would look even better if its window border were removed and the background of the MIDI MESSAGE indicator matched the black case of the MT-32.

A bonus would be if mt32emu_qt had a dark theme option.

mt32emu_qt 2.7 AppImage | Cinnamon 5.2.7 | Linux Mint 20.3

@sergm
Copy link
Member

sergm commented Jun 4, 2022

I guess, you looked at it on Cinnamon desktop, right? Then I am not sure I get the request, because that seems to be already implemented (as can be seen on the screenshot attached to #94).

AFAICT, Qt applications rely on the system theme by default, so adding just a dark custom theme would be a bit strange. I don't mind adding support for setting a configurable style though, but definitely not limited to just dark one.

@ParticleMon
Copy link
Author

At least for me, with a dark theme in Cinnamon, Munt has a light theme.

@sergm
Copy link
Member

sergm commented Jun 4, 2022

Right, for me too as long as I am using the bundled appimage. Native build is not isolated from the DE and uses the system default style, I assume. But I am not too involved into Qt internals, so may be wrong.

@ParticleMon
Copy link
Author

ParticleMon commented Jun 4, 2022

Gotcha. Although I prefer native builds, I use AppImages (or the like) only when necessary. Unfortunately, mt32emu_qt has been one such case.

A previous attempt to build mt32emu failed. But attempting to build 2.6.2 worked! As one who is not a developer, I find the instructions vague but at least what is described to "probably" work does work to build mt32emu. And with the steps required to build mt32emu_qt remaining unclear, I attempted to build it according to the same instructions as mt32emu, and it worked! More verbose instructions might also be very appreciated by others. (Next mystery to solve: how to add compiler optimizations.)

However, it can be executed only in the source tree. Executing the installed binary throws the following, although the relevant files are in /usr/local/lib:
"mt32emu-qt: error while loading shared libraries: libmt32emu.so.2: cannot open shared object file: No such file or directory"

As expected, the native mt32emu_qt uses the system theme (dark).

@sergm
Copy link
Member

sergm commented Jun 5, 2022

Oh well, the instructions really seem unclear 😕
OTOH, you might find the pre-built binary packages useful. Also, a few GNU distributions have mt32emu library incorporated, so worth having a look around.

@ParticleMon
Copy link
Author

For some forgotten reason, I have been usnig snapshots, of which pre-built binaries have not been provided.

Since a .deb works (at least now), this issue is solved.

But this leads to a question: Why not post all releases here?

@sergm
Copy link
Member

sergm commented Jun 6, 2022

Since a .deb works (at least now), this issue is solved.

I still think that adding support for configurable palettes is a bad idea, but this has now a lower priority if you say so.

But this leads to a question: Why not post all releases here?

We do plan to involve GitHub actions soon-ish, so that development snapshots should be available here. But official releases seemingly remain where they are.

@ParticleMon
Copy link
Author

At this point, I'm not requesting a theme selector. However, I remain curious how the LCD would look and function, regardless of theme, borderless and in black.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants