Pattern Matching

[mtk3d]

Here is my proposition for pattern matching 😃
Unfortunately, the "case", and "match" (the "match" since PHP8.0) are reserved words, so I used the "Generic" prefix, but I'm not sure if this is ok.
I added a new ignore statement to PHPStan. I have no idea where is the problem, everything looks ok, especially that this part was not changed by me 🤔 .

[codecov]

Codecov Report

Merging #59 (f328bed) into master (486f85c) will increase coverage by 0.76%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #59      +/-   ##
============================================
+ Coverage     93.54%   94.30%   +0.76%     
- Complexity      431      463      +32     
============================================
  Files            31       48      +17     
  Lines           899      984      +85     
============================================
+ Hits            841      928      +87     
+ Misses           58       56       -2     

Impacted Files	Coverage Δ
src/GenericMatch.php	100.00% <100.00%> (ø)
src/Match/DefaultCase.php	100.00% <100.00%> (ø)
src/Match/DefaultCase/DefaultCaseCallable.php	100.00% <100.00%> (ø)
src/Match/DefaultCase/DefaultCaseStatic.php	100.00% <100.00%> (ø)
src/Match/GenericCase.php	100.00% <100.00%> (ø)
src/Match/GenericCase/GenericCaseCallable.php	100.00% <100.00%> (ø)
src/Match/GenericCase/GenericCaseStatic.php	100.00% <100.00%> (ø)
src/Match/Predicates/IsAllOf.php	100.00% <100.00%> (ø)
src/Match/Predicates/IsAnyOf.php	100.00% <100.00%> (ø)
src/Match/Predicates/IsIn.php	100.00% <100.00%> (ø)
... and 25 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 486f85c...f328bed. Read the comment docs.

[akondas]

Thanks. I appreciate the work.
Nevertheless, since version 8 we have native support: https://www.php.net/manual/en/control-structures.match.php

So I wonder what would that get us? Are there any cases where munus would give something better?

[akondas]

What do you think about more functional way (with functions for shorter notations):

$result = matchValue(1)->of(case(isNotNull(), 'match'), case('other'));

That code at the top could actually produce what's at the bottom. Such syntactic sugar 😉

$result = GenericMatch::value(1)->of(
    GenericCase::of(Is::notNull(), 'match'),
    DefaultCase::of('other')
);

[mtk3d]

Yeah, the functional way looks very nice. How do you think to do that? Just wrap the existing classes into functions?

So I wonder what would that get us? Are there any cases where munus would give something better?

I thought only about the older version of PHP, the native PHP8 match is the best option I think.
This work just gave me some fun and was an exercise for me, so I already get the value for myself. Pull request is the additional thing for me. So if you don't want to add the match for older PHP versions to munus, that's ok, just close this PR 😄

[akondas]

Will happily merge this pull request, even if native support is better.
And yes, "wrap the existing classes into functions" that was what I meant.

[mtk3d]

Great! 😄
I just added a new commit that wraps matching into functions. It looks much better now 💪

[akondas]

It turned out really elegant. 👏 👍
Let this warm on the master for a moment and we will release it 🚀