Merge pull request #479 from fzurita/check_zip_contents

Fix issue that allowed any extracted file to be considered a ROM
mupen64plus-ae · Oct 7, 2015 · 0929d79 · 0929d79
2 parents 74c3934 + 41cfc89
commit 0929d79
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/src/paulscode/android/mupen64plusae/task/CacheRomInfoService.java b/src/paulscode/android/mupen64plusae/task/CacheRomInfoService.java
@@ -181,7 +181,12 @@ else if( header.isZip && mSearchZips )
                                 if( mbStopped ) break;
                                 if( extractedFile != null )
                                 {
-                                    cacheFile( extractedFile, database, config, file );
+                                    RomHeader extractedHeader = new RomHeader( extractedFile );
+                                    if(extractedHeader.isValid)
+                                    {
+                                        cacheFile( extractedFile, database, config, file );
+                                    }
+
                                     extractedFile.delete();
                                 }