Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELATED TO ISSUE #692] - SDL audio plugin #699

Closed
ZacharyFoxx opened this issue Jul 5, 2018 · 10 comments
Closed

[RELATED TO ISSUE #692] - SDL audio plugin #699

ZacharyFoxx opened this issue Jul 5, 2018 · 10 comments

Comments

@ZacharyFoxx
Copy link

Hi,

Sorry, I took long to reply in the issue #692.

My device is the OUYA, which Tegra 3 and I´m using a custom ROM, Lineage OS 11, based on KitKat.

I setted the sampling rate to "best for hardware" and I disable "Synchronize audio and video", but the difference of performance still huge and in some games, like Cruis'n Usa, these settings left the game playing worse.

Even in the same version, 121, there is difference in performance between use the SDL sound plugin or the SLES.

@fzurita
Copy link
Member

fzurita commented Jul 5, 2018

Did you also disable audio time stretching?

@ZacharyFoxx
Copy link
Author

Yeap! Believe me, I tried everything that you can imagine and more, like does not use an USB HUB and I didn't can find the setting "Floating point samples".

@fzurita
Copy link
Member

fzurita commented Jul 5, 2018

If you disable audio by setting the audio plugin to "none-debug", does performance improve? Make sure you disable synchronize audio and video when you do that, otherwise there will be no frame limiter.

@ZacharyFoxx
Copy link
Author

I'll try it tonight and I tell you after.

@ZacharyFoxx
Copy link
Author

I tested using the setting "none-debug". Independently of the game, Cruis'n USA, GoldenEye, Pilotwings, they all ran well with this setting, keeping a good fps.

@fzurita
Copy link
Member

fzurita commented Jul 7, 2018

Ok, I can do a more optimized audio SLES plugin that bypasses the sound touch library with lower quality audio. I won't bring back the SDL audio plugin though.

@ZacharyFoxx
Copy link
Author

Hi. Great! I'll be thankful for this.
But, could you tell me why you don't want bring the SDL audio plugin back? I'm curious about it because the SDL audio plugin is lighter than SLES plugin and to you should be easiest put the SDL audio plugin back.

@fzurita
Copy link
Member

fzurita commented Jul 11, 2018

SLES is lighter than SDL. SDL is wrapper around the native Android audio, which would be slower in my opinion. What could be making SLES slower for you could be the SoundTouch library that we use for resampling the audio. If we skip the SoundTouch library and let Android do the resampling it may be faster for you. So I will try that.

@ZacharyFoxx
Copy link
Author

I got it! Again, thank you for all effort :D.

@fzurita
Copy link
Member

fzurita commented Feb 11, 2019

Ok, done: 0b736b6

@fzurita fzurita closed this as completed Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants