new_dynarec: fix FPU crashes #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fix the new dynarec crashes on ARM and ARM64 platforms since the interpreter accuracy improvements, a RMG user reported it a while back and I made this experimental patch for it which fixes it (tested it on my pinebook pro aswell).
I had no idea the new dynarec called the FPU functions from
fpu.h, and for some reason it kept working fine on x86_64, so I didn't notice it at all until the report came in from a RMG user, after some discussion with @m4xw, he said that we could best wait for @Gillou68310 to come up with a proper patch, but that was a while ago already, so to correct my mistake, I'm offering my patch, which could be improved later by Gillou if he wants to, but it fixes the crashes now instead of later, so users who are trying the latest git version of mupen64plus won't be hit by this bug anymore, but it's upto you (the maintainers) whether you agree with my thoughts on that or not.This code was written by looking at other FPU functions which already had fcr31 pointer as first argument before my changes, so I copied that dynarec code and placed it everywhere where needed, which solves the crashes.
Fixes #1026