Fix LLVM warnings and OpenBSD build failures #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The second part of the credit cheat were executed independenly of the first part. This was caused but the wrong syntax used for the if statement in commit 8e14cc9 ("Add Missing Subscreen Delay Fix for Ocarina of Time")
The JR_IDLE and JALR_IDLE functions are unused in the pure interpreter and cached interpreter. Thus these functions are marked with the attribute "unused". Unfortunatelly, the declaration did not precede the definition. Also the definition conflicted with the declaration.
OpenBSD doesn't seem to have the definition for __GNUC_PREREQ and thus fails to i386 with PIC enabled (which is the default now).
richard42
added a commit
that referenced
this pull request
Jan 14, 2014
Fix LLVM warnings and OpenBSD build failures
Closed
Closed
Open
Open
bsmiles32
pushed a commit
to bsmiles32/mupen64plus-core
that referenced
this pull request
Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.