Fix New Dynarec build failures arising from commit bdb8a88

[Nebuleon]

Hopefully fixes #94. I looked in the new subdirectories of new_dynarec and this should fix all inclusion issues.

[Narann]

@Gillou68310, can you confirm this fix #94? :)

[gizmo98]

Checked. new_dynarec arm is working!

[Gillou68310]

Thanks for taking care of this @Nebuleon ;-)
But I think that cp0_private.h and main.h could actually be removed from assem_arm.c as they are already included in new_dynarec.c.

[Narann]

Do you think what @Gillou68310 said is relevant @Nebuleon? If so, you can update this PR before I merge it.

[Gillou68310]

@Narann is it possible to ask travis to build both old and new dynarec so we won't end up with those kind a errors?

[Nebuleon]

arm/assem_arm.c and new_dynarec.c are different compilation units; including cp0_private.h in the latter would have no effect in the former. The ARM-specific file requires g_cp0_regs (for example, line 1165 of assem_arm.c as of commit f648835), so it should continue to include cp0_private.h (at the proper path).

wow, including .c files in .c files... I really don't like this, but if assem_PLATFORM.c is never compiled on its own, only as part of new_dynarec.c, that could work. However, it's still good practice to keep the includes required by the included .c file.

[Narann]

Good idea @Gillou68310!

But I have no idea how to do that. I've created a ticket #96.

[Gillou68310]

wow, including .c files in .c files... I really don't like this.

Yeah I agree that's not the best practice!

Ok I think we can leave these include files for the moment, but the new dynarec will need a big cleanup at some point.

Good idea @Gillou68310!
But I have no idea how to do that. I've created a ticket #96.

Thanks @Narann I will check this!