Allow external state callback to be specified via build flag... #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for not answer to your previous message (I read it but had no real opinion on this). You PR seems clean but I will let @richard42 approve it. :) |
|
I'll update it with the comment shortly. I forget that not everyone uses git blame :) |
... and allow main() to be called by external module. Useful for UI implementations that simply layer on top of ui-console (rather than reimplement it). In such cases, ui-console can be built as a library rather than top-level executable. The higher-level UI can then "launch" the ui-console implementation in its own process/thread by calling main directly (rather than spawning a separate ui-console process). This is not only a general convenience, but also allows the higher-level UI to provide a state callback to synchronize its display. This commit facilitates downstream UI development, but is not likely to be of interest to general users who build ui-console from makefile. Therefore, the CALLBACK_* build flags are omitted from the makefile help text.
|
Updated and ready. Thanks @Narann |
richard42
added a commit
that referenced
this pull request
Jan 10, 2015
Allow external state callback to be specified via build flag...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and allow main() to be called by external module.
Useful for UI implementations that simply layer on top of ui-console
(rather than reimplement it). In such cases, ui-console can be built as
a library rather than top-level executable. The higher-level UI can
then "launch" the ui-console implementation in its own process/thread
by calling main directly (rather than spawning a separate ui-console
process). This is not only a general convenience, but also allows the
higher-level UI to provide a state callback to synchronize its display.
This commit facilitates downstream UI development, but is not likely to
be of interest to general users who build ui-console from makefile.
Therefore, the CALLBACK_* build flags are omitted from the makefile help
text.