New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto_sign and crypto_sign_detached throwing invalid mem access (windows) #1
Comments
I added another unit test By the way, I did not get any pull request. Thanks. |
Hi - sorry I must have messed up the merge. But I am not using secretboxdetached (which is authentication). I amd trying public key signatures. But here are the 4 new functions that I do have that do work fine: `
So these 2 work great, now, on my 64bit windows with latest libsodium, and eclipse64bitneon, and java 64bit 1.8.0_144. Notice that we are actually successful at creating the signing private key and the signed public key, we just cannot implement any signing operations - the issue is for me also trying to add support for function crypto_sign_detached. here is what I am trying to implement
but eclipse errors out with
Id be more than happy to work with you to troubleshoot this. (I really need to get signatures to work, and kalium is such a massive pain with its massive dependencies) |
It appears you did not generate the key pair, you just created bunch of bytes. SodiumKeypair is just a place holder, it does not generate pair. Generate the pair by calling Thanks. |
cryptoBoxKeyPair is for public key authentication encryption. I am working on public key signatures here - not auth/encryption. but i figured out the issue; it was something non-intuitive inside libsodium itself for the sign/open pieces whereby instead of passing the actual length of the resulting message you want back, you must just pass a zero instead of the length; so whatever I guess. seems odd. its all working now, so now I have 4 very nice functions for you now - if you'd like to help me out with the proper way to merge? I thought did it the other day, and from all indications it looks like it completed, but ive just never done this before. btw thanks for this excellent library, its been extremely helpful for what I am tryign to achieve here. |
That's great! For your new code, you can try again to send a pull request. Otherwise if possible, you can do the following:
Thanks. |
Hi, I have just attempted this again, please check to see if you see my
data now
…On Thu, Oct 5, 2017 at 7:08 PM, muquit ***@***.***> wrote:
That's great! For your new code, you can try again to send a pull request.
Otherwise if possible, you can do the following:
- Document the API in README.md
- Javadoc comments in the source
- Add Unit tests for the API
Then zip the files up and email me, I will merge.
Thanks.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKQ5UDlamaA12ID4eLC-IkQu8Uqi_m0iks5spW-WgaJpZM4PuNGy>
.
|
Update SodiumLibrary.java for support for signing, blake2b generic ha…
You pull request is merged. If possible, please update the README.md about the APIs you added. |
Not sure why these wont work (the 2 verify ones also fail with same error). I do already have many of your libsodium-jna functions working normally. I have also implemented a few new ones for you and have recently pushed them to you for merge.
But these ones just seem to fail. (using eclipse neon 64 and jre 1.8.0_144
The text was updated successfully, but these errors were encountered: