Add JSON payload parser support in step-definition #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micaelbergeron
force-pushed
the
add/payload-parser
branch
from
d2f9b98
to
f9f538d
Compare
ralsina
approved these changes
May 12, 2023
This change enabled step definitions to declare a parsed payload
Given('…', (...args) => { … }, { parser: 'json' | 'json5' })
This will remove the need to JSON.parse in every step-def.
micaelbergeron
force-pushed
the
add/payload-parser
branch
from
f9f538d
to
0eb188a
Compare
ralsina
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change enabled step definitions to declare a parsed payload
This will remove the need to JSON.parse in every stepdef and comes with a JSON5 parser for our human fingers.