Remove open system call for Darwin #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatically opening a torrent via system call is an intrusive operation. Tors is a torrent search utility and it shouldn't assume that the user has a torrent client installed. It should be up to the user whether to open it or not. Resolves murat#3
|
@eren maybe you are right. But I was planned make an option for open or don't open. Can you make this? |
|
Yeah. I can send a PR for adding an option but it shouldn't be a blocker for this. It should be a default behavior not to open files. |
|
Yep we have same thoughts. I'm waiting your pr. |
- Add -o/--open parameter on Darwin platform which defaults to false - Refactor TorS::Search to accept a block on initialization stage - Handle exception better on download by changing ensure statement to else. Ensure block always runs regardless of the error. We want to run this block if the download is successful. Resolves murat#3
|
Thanks very much @eren Best regard! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically opening a torrent via system call is an intrusive
operation. Tors is a torrent search utility and it shouldn't assume that
the user has a torrent client installed. It should be up to the user
whether to open it or not.
Resolves #3