Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove open system call for Darwin #4

Merged
merged 2 commits into from Sep 1, 2017
Merged

Remove open system call for Darwin #4

merged 2 commits into from Sep 1, 2017

Commits on Sep 1, 2017

  1. Remove open system call for Darwin 

    Automatically opening a torrent via system call is an intrusive
operation. Tors is a torrent search utility and it shouldn't assume that
the user has a torrent client installed. It should be up to the user
whether to open it or not.

Resolves murat#3
    @eren
    eren committed Sep 1, 2017
    Configuration menu
    Copy the full SHA
    1aca6d5 View commit details
    Browse the repository at this point in the history

  2. Add -o/--open parameter and refactor class definition 

    - Add -o/--open parameter on Darwin platform which defaults to false
- Refactor TorS::Search to accept a block on initialization stage
- Handle exception better on download by changing ensure statement to else.
  Ensure block always runs regardless of the error. We want to run this block
  if the download is successful.

Resolves murat#3
    @eren
    eren committed Sep 1, 2017
    Configuration menu
    Copy the full SHA
    1bf3b2d View commit details
    Browse the repository at this point in the history