Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found an issue where nested wildcards are not matched. I've rewritten the folder matcher code to use recursion to find the correct folder.
Assuming the a folder structure like:
Desired situation:
GET lvl1/1/lvl2/1/lvl3 => (d)
GET lvl1/8/lvl2/1/lvl3 => (b)
GET lvl1/1/lvl2/8/lvl3 => (c)
GET lvl1/8/lvl2/8/lvl3 => (a)
At the moment, if file (d) would not exist, it will result in a 404 not found when lvl1/1/lvl2/1/lvl3 is requested. Expected is that (c) would be returned. This is because the folder lvl1/1/lvl2/1 actually does exist, and the matcher doesn't look back once it finds an non existent folder.
With the changed code, the matching strategy will be as follows (first one that matches wins), stars indicate where a possible wildcard could be: