Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discogs script only partially working #413

Open
morrinson opened this issue Aug 20, 2021 · 5 comments
Open

Discogs script only partially working #413

morrinson opened this issue Aug 20, 2021 · 5 comments

Comments

@morrinson
Copy link

The script fails to open the import button in the sidebar, but all the other buttons / links (for label, artist, etc. redirections to MusicBrainz) are properly showing.
I've tried basically everything, log out and back in, deactivate ad blocker, change language, manually update and reinstall script, but the same behavior happens on three different computers (all with Firefox / Windows).

unknown

@liftarn
Copy link
Contributor

liftarn commented Aug 31, 2021

@morrinson
Copy link
Author

Same error message on my side with respect to this release.
Regarding the original issue of this thread, it seems to have been corrected since. I leave the issue open just in case it is helpful for the issue mentioned by liftarn.

@kellnerd
Copy link
Collaborator

@liftarn The importer script interprets tracks 14.1 and 14.2 as medium 14, tracks 1 and 2, and fails because this leaves a huge gap between medium 1 and "14".
Not sure whether this should be fixed in the importer because Discogs also allows subtracks to be entered properly which are then correctly parsed by the importer.
But I think there has to be a general decision on how the script should deal with subtracks first:

@lyz-code
Copy link

lyz-code commented Dec 3, 2021

@morrinson were you able to make it work? It worked for me once I clicked on a specific release. You can't import the master release

@morrinson
Copy link
Author

@lyz-code Yeah it finally worked (after a fix around 31 Aug I guess). But it was not for a master, which indeed cannot be imported. The original post's screenshot was related to this page: https://www.discogs.com/release/15672190-Chui-Wan-Eye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants