Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Irssi: IrssiNotifier: previous send is still in progress and queue is full, skipping notification #161

Closed
bsdlp opened this issue Dec 3, 2013 · 4 comments · Fixed by #162
Closed

Irssi: IrssiNotifier: previous send is still in progress and queue is full, skipping notification #161

bsdlp opened this issue Dec 3, 2013 · 4 comments · Fixed by #162
Milestone
1.8

Comments

@bsdlp
Copy link

bsdlp commented Dec 3, 2013

Irssi: IrssiNotifier: previous send is still in progress and queue is full, skipping notification

00:54 <@murgo> jchen: that's a rare but known issue
00:54 <@murgo> /script unload irssinotifier and then /script load irssinotifier

Error appears to be thrown when $forked != 1:

https://github.com/murgo/IrssiNotifier/blob/master/Irssi/irssinotifier.pl#L201
@qvr
Copy link
Contributor

qvr commented Dec 9, 2013

When this happens is there a stuck wget command still running (and another (forked) instance of irssi)? Cant see how it could happen otherwise.

@bsdlp
Copy link
Author

bsdlp commented Dec 9, 2013

hasn't happened to me lately (or I miss the message). Then again, I haven't been receiving notifications on my phone either.

@amodig
Copy link

amodig commented Mar 26, 2014

I had this same issue. At least, the error note should say that one needs to reload the script.

qvr added a commit to qvr/IrssiNotifier that referenced this issue Mar 26, 2014
@qvr
Script: simplify encryption, try to avoid getting stuck
e31dcd6 
Remove fork() from encryption, by passing shared fd to openssl
instead of named pipes. If the fork() failed for any reason in
encrypt(), the openssl process would block forever waiting for data
in the pipe.

Also fix a situation where if the first fork() in send_to_api()
failed, script would not retry ever again as the global $forked
variable wasn't reset.

This should hopefully fix murgo#161
@qvr qvr mentioned this issue Mar 26, 2014
Merged
@murgo murgo closed this as completed in #162 Apr 1, 2014
@murgo
Copy link
Owner

murgo commented Apr 1, 2014

I never actually managed to reproduce this, but I received numerous reports about it. Could you try with the latest script in the Github repo and report if there are any issues?

@murgo murgo added this to the 1.8 milestone Apr 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8
Development

Successfully merging a pull request may close this issue.

Script: simplify encryption, try to avoid getting stuck qvr/IrssiNotifier
4 participants
@qvr @bsdlp @amodig @murgo