Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: my total modifications #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KomeijiSatori
Copy link

This is my modification which meets my own requirements, you may not merge, just take a look :D. You may fetch my code and run for fun~
I have refactored a lot of your code. From my point of view, your code style may not be easy to read and modify, and some parts can be optimized. You may take a look at my modification, maybe there are some parts you can adopt. And I list some important modifications in my readme.md.
And thank you for your effort, I have been inspired a lot from your code, you've done well~
@murongqimiao

@Zheaoli
Copy link

Zheaoli commented Oct 12, 2019

Hello bro

would you mind to split this PR into couples PRs? just make sure one PR for one thing.

And I guess maybe you should solve the file conflict fist?

Copy link

@wszgxa wszgxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you resolve the conflicts first?

@KomeijiSatori
Copy link
Author

Could you resolve the conflicts first?

Hi, I started developing from commit 2e327b9
So if you reset hard from that commit, and replace all files with my new changes, you will not see conflicts.

@KomeijiSatori
Copy link
Author

Hello bro

would you mind to split this PR into couples PRs? just make sure one PR for one thing.

And I guess maybe you should solve the file conflict fist?

Thank you for your suggestions, but I actually develop from my company, and any previous commits are removed, sorry for the inconvenience. And I'm not intend to merge this pull requests because I remove some features from the origin repo. If you are interested in what I have changed, I suggest write an email to me and I will explain in detail, thanks for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants