extract pageLinks to improve readability

murrant · Jun 14, 2024 · af767a1 · af767a1
1 parent 53c5328
commit af767a1
Showing 1 changed file with 36 additions and 31 deletions.
diff --git a/app/Http/Controllers/Device/Tabs/PortsController.php b/app/Http/Controllers/Device/Tabs/PortsController.php
@@ -87,44 +87,14 @@ public function data(Device $device, Request $request): array
             default => $this->portData($device, $request),
         };
 
-        $disabled = $request->input('disabled');
-        $ignore = $request->input('ignore');
-        $admin = $request->input('admin') == 'any';
-        $status = $request->input('status') == 'up';
-
         return array_merge([
             'tab' => $tab,
             'details' => $this->detail,
             'submenu' => [
                 $this->getTabs($device),
                 __('Graphs') => $this->getGraphLinks(),
             ],
-            'page_links' => [
-                [
-                    'icon' => $status ? 'fa-regular fa-square-check' : 'fa-regular fa-square',
-                    'url' => $status ? $request->fullUrlWithoutQuery('status') : $request->fullUrlWithQuery(['status' => 'up']),
-                    'title' => __('port.filters.status_up'),
-                    'external' => false,
-                ],
-                [
-                    'icon' => $admin ? 'fa-regular fa-square-check' : 'fa-regular fa-square',
-                    'url' => $admin ? $request->fullUrlWithoutQuery('admin') : $request->fullUrlWithQuery(['admin' => 'any']),
-                    'title' => __('port.filters.admin_down'),
-                    'external' => false,
-                ],
-                [
-                    'icon' => $disabled ? 'fa-regular fa-square-check' : 'fa-regular fa-square',
-                    'url' => $disabled ? $request->fullUrlWithoutQuery('disabled') : $request->fullUrlWithQuery(['disabled' => 1]),
-                    'title' => __('port.filters.disabled'),
-                    'external' => false,
-                ],
-                [
-                    'icon' => $ignore ? 'fa-regular fa-square-check' : 'fa-regular fa-square',
-                    'url' => $ignore ? $request->fullUrlWithoutQuery('ignore') : $request->fullUrlWithQuery(['ignore' => 1]),
-                    'title' => __('port.filters.ignored'),
-                    'external' => false,
-                ],
-            ],
+            'page_links' => $this->pageLinks($request),
             'perPage' => $this->perPage,
             'sort' => $this->sortOrder,
             'next_order' => $this->sortOrder == 'asc' ? 'desc' : 'asc',
@@ -390,4 +360,39 @@ private function parseTab(Request $request): string
 
         return $request->route('vars', 'detail'); // fourth segment is called vars to handle legacy urls
     }
+
+    private function pageLinks(Request $request): array
+    {
+        $disabled = $request->input('disabled');
+        $ignore = $request->input('ignore');
+        $admin = $request->input('admin') == 'any';
+        $status = $request->input('status') == 'up';
+
+        return [
+            [
+                'icon' => $status ? 'fa-regular fa-square-check' : 'fa-regular fa-square',
+                'url' => $status ? $request->fullUrlWithoutQuery('status') : $request->fullUrlWithQuery(['status' => 'up']),
+                'title' => __('port.filters.status_up'),
+                'external' => false,
+            ],
+            [
+                'icon' => $admin ? 'fa-regular fa-square-check' : 'fa-regular fa-square',
+                'url' => $admin ? $request->fullUrlWithoutQuery('admin') : $request->fullUrlWithQuery(['admin' => 'any']),
+                'title' => __('port.filters.admin_down'),
+                'external' => false,
+            ],
+            [
+                'icon' => $disabled ? 'fa-regular fa-square-check' : 'fa-regular fa-square',
+                'url' => $disabled ? $request->fullUrlWithoutQuery('disabled') : $request->fullUrlWithQuery(['disabled' => 1]),
+                'title' => __('port.filters.disabled'),
+                'external' => false,
+            ],
+            [
+                'icon' => $ignore ? 'fa-regular fa-square-check' : 'fa-regular fa-square',
+                'url' => $ignore ? $request->fullUrlWithoutQuery('ignore') : $request->fullUrlWithQuery(['ignore' => 1]),
+                'title' => __('port.filters.ignored'),
+                'external' => false,
+            ],
+        ];
+    }
 }