nn unit tests #236
Merged
nn unit tests #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FlowTracker and SimpleTracker and now wrappers around a generic Tracker class which can use a FlowCandidateMaker or SimpleCM. Attributes specific to the flow/simple procedures have been moved off the Tracker object and onto the specific CM class. Note that tracker code still doesn't have unit tests but I ran integration tests to confirm that refactoring doesn't affect algorithms/results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for functions in
Also, refactor nn.tracking to remove code overlap between different tracking methods.