Fix JSON::ParserError when image data is an invalid json string #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
musaffa
requested changes
Apr 4, 2020
spec/integration/file_content_type_validation_integration_spec.rb
Outdated
Show resolved
Hide resolved
spec/integration/file_content_type_validation_integration_spec.rb
Outdated
Show resolved
Hide resolved
musaffa
reviewed
Apr 4, 2020
musaffa
requested changes
Apr 4, 2020
|
@gael-ian Your PR has been merged. Thanks! ❤️ |
|
The pleasure is mine ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This pull request should fix the
JSON::ParserErrorraised when one of the validator is fed with an invalid JSON string (issue #20).Talking about validations, you always have to decide wether something will be considered valid or not. I choose to handle invalid JSON strings as invalid values and to add an error to the record. That's why are exceptions are rescued at this level instead of in the
parse_valuesmethods of each validator: I needed the record and attribute to add the error and did not want to pass them toparse_values.The error message use the default
:invalidmessage, as there's no need to be more precise. Invalid JSON string are not common things and are mostly due to nasty bots trying to break in an application. I don't think we need to be more explicit on this.I hope you'll find the time to merge this soon.
Thanks