Skip to content

Commit

Permalink
ipq40xx: fix 4.14 ImageBuilder build woes
Browse files Browse the repository at this point in the history
Robert Marko reported an issue with the current imagebuilder images:
"Imagebuilder includes the new kmod-usb-dwc3-qcom USB driver
package by default even on 4.14. [...] the current state imagebuilder
can't build images under 4.14 at all as the kmod-usb-dwc3-qcom does
not exist in it so it throws and error and exits."

This patch reverts the Makefile to just kmod-usb-dwc3-of-simple and
once the switch to 4.19 is done. It also removes the
kmod-usb-phy-qcom-dwc3 as they only contain the usb-phy drivers for
the ipq806x generation.

Dynamic switching based on the KERNEL_PATCHVER is possible by using:
   $(if $(filter 4.14,$(KERNEL_PATCHVER)),kmod-usb-dwc3-of-simple,kmod-usb-dwc3-qcom)
though it

Fixes: 13321fa ("ipq40xx: Use kmod-usb-dwc3-qcom by default")
Fixes: 6e58fb2 ("ipq40xx: kmod-usb-dwc3-of-simple vs kmod-usb-dwc3-qcom")
Reported-by: Robert Marko <robimarko@gmail.com>
Signed-off-by: Christian Lamparter <chunkeey@gmail.com>
  • Loading branch information
chunkeey committed Jan 5, 2019
1 parent 3801f8a commit 32e953b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions target/linux/ipq40xx/Makefile
Expand Up @@ -15,9 +15,9 @@ KERNELNAME:=zImage Image dtbs

include $(INCLUDE_DIR)/target.mk
DEFAULT_PACKAGES += \
kmod-usb-dwc3-of-simple \
kmod-leds-gpio kmod-gpio-button-hotplug swconfig \
kmod-ath10k-ct wpad-basic \
kmod-usb3 kmod-usb-dwc3-of-simple kmod-usb-phy-qcom-dwc3 \
kmod-usb-dwc3-qcom ath10k-firmware-qca4019-ct
kmod-usb3 kmod-usb-dwc3 ath10k-firmware-qca4019-ct

$(eval $(call BuildTarget))

0 comments on commit 32e953b

Please sign in to comment.