Skip to content

Commit

Permalink
dropbear: add config options for agent-forwarding support
Browse files Browse the repository at this point in the history
* SSH agent forwarding might cause security issues, locally and on the jump
  machine (https://defn.io/2019/04/12/ssh-forwarding/). So allow to
  completely disabling it.
* separate options for client and server
* keep it enabled by default

Signed-off-by: Sven Roederer <devel-sven@geroedel.de>
  • Loading branch information
SvenRoederer authored and chunkeey committed Oct 30, 2021
1 parent 88a2ea4 commit 5287def
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
9 changes: 9 additions & 0 deletions package/network/services/dropbear/Config.in
Expand Up @@ -95,6 +95,11 @@ config DROPBEAR_DBCLIENT
bool "Build dropbear with dbclient"
default y

config DROPBEAR_DBCLIENT_AGENTFORWARD
bool "Enable agent forwarding in dbclient"
default y
depends on DROPBEAR_DBCLIENT

config DROPBEAR_SCP
bool "Build dropbear with scp"
default y
Expand All @@ -109,4 +114,8 @@ config DROPBEAR_ASKPASS

Increases binary size by about 0.1 kB (MIPS).

config DROPBEAR_AGENTFORWARD
bool "Enable agent forwarding"
default y

endmenu
5 changes: 4 additions & 1 deletion package/network/services/dropbear/Makefile
Expand Up @@ -32,7 +32,8 @@ PKG_CONFIG_DEPENDS:= \
CONFIG_DROPBEAR_CURVE25519 CONFIG_DROPBEAR_ZLIB \
CONFIG_DROPBEAR_ED25519 CONFIG_DROPBEAR_CHACHA20POLY1305 \
CONFIG_DROPBEAR_UTMP CONFIG_DROPBEAR_PUTUTLINE \
CONFIG_DROPBEAR_DBCLIENT CONFIG_DROPBEAR_SCP CONFIG_DROPBEAR_ASKPASS
CONFIG_DROPBEAR_DBCLIENT CONFIG_DROPBEAR_SCP CONFIG_DROPBEAR_ASKPASS \
CONFIG_DROPBEAR_DBCLIENT_AGENTFORWARD CONFIG_DROPBEAR_AGENTFORWARD

include $(INCLUDE_DIR)/package.mk

Expand Down Expand Up @@ -135,6 +136,8 @@ DB_OPT_CONFIG = \
!!DROPBEAR_ECC_384|CONFIG_DROPBEAR_ECC_FULL|1|0 \
!!DROPBEAR_ECC_521|CONFIG_DROPBEAR_ECC_FULL|1|0 \
DROPBEAR_CLI_ASKPASS_HELPER|CONFIG_DROPBEAR_ASKPASS|1|0 \
DROPBEAR_CLI_AGENTFWD|CONFIG_DROPBEAR_DBCLIENT_AGENTFORWARD|1|0 \
DROPBEAR_SVR_AGENTFWD|CONFIG_DROPBEAR_AGENTFORWARD|1|0 \


TARGET_CFLAGS += -DARGTYPE=3 -ffunction-sections -fdata-sections -flto
Expand Down

0 comments on commit 5287def

Please sign in to comment.