Skip to content

Commit

Permalink
realtek: Improve IRQ request in Ethernet driver
Browse files Browse the repository at this point in the history
Improves the IRQ request code by using platform_get_irq() which provides
better error handling.

Signed-off-by: Birger Koblitz <git@birger-koblitz.de>
  • Loading branch information
Birger Koblitz authored and dangowrt committed Feb 17, 2022
1 parent a75b9e3 commit a825835
Showing 1 changed file with 4 additions and 5 deletions.
Expand Up @@ -2209,14 +2209,13 @@ static int __init rtl838x_eth_probe(struct platform_device *pdev)

spin_lock_init(&priv->lock);

/* obtain device IRQ number */
res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
if (!res) {
/* Obtain device IRQ number */
dev->irq = platform_get_irq(pdev, 0);
if (dev->irq < 0) {
dev_err(&pdev->dev, "cannot obtain IRQ, using default 24\n");
dev->irq = 24;
} else {
dev->irq = res->start;
}

dev->ethtool_ops = &rtl838x_ethtool_ops;
dev->min_mtu = ETH_ZLEN;
dev->max_mtu = 1536;
Expand Down

0 comments on commit a825835

Please sign in to comment.