Skip to content

Commit

Permalink
ubox: fix broken deferred start of logfile writer
Browse files Browse the repository at this point in the history
Just use 'start' action which will have the desired effect instead of
trying to introduce a 'start_file' action which didn't work that way
because procd jshn magic would have to wrap around it.

Fixes: 88baf6c ("ubox: only start log to file when filesystem has been mounted")
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
  • Loading branch information
dangowrt committed Jan 31, 2022
1 parent 9ba7a83 commit b6a2cee
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions package/system/ubox/files/log.init
Expand Up @@ -9,8 +9,6 @@ PIDCOUNT=0
USE_PROCD=1
PROG=/sbin/logread

extra_command "start_file" "Start writing to log file"

validate_log_section()
{
uci_load_validate system system "$1" "$2" \
Expand Down Expand Up @@ -90,7 +88,7 @@ start_service_remote()

register_mount_trigger()
{
[ -n "${log_file}" ] && procd_add_action_mount_trigger start_file "${log_file}"
[ -n "${log_file}" ] && procd_add_action_mount_trigger start "${log_file}"
}

service_triggers()
Expand All @@ -109,12 +107,6 @@ start_service()
config_foreach validate_log_section system start_service_remote
}

start_file()
{
config_load system
config_foreach validate_log_section system start_service_file
}

boot() {
_BOOT=1 start
}

0 comments on commit b6a2cee

Please sign in to comment.