Skip to content

Commit

Permalink
layerscape: mkits-multiple-config: fail on invalid arguments
Browse files Browse the repository at this point in the history
Fail if arguments couldn't be parsed and print unrecognized part. It's
important when running it from script with dynamic values. Missing value
could result in skipping argument and silent failures (unexpected its).

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
  • Loading branch information
Rafał Miłecki committed Nov 8, 2021
1 parent a02c971 commit b8bbac9
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions target/linux/layerscape/image/mkits-multiple-config.sh
Expand Up @@ -198,6 +198,11 @@ parse_args() {
usage;;
esac
done
shift $(($OPTIND - 1))
[ $# -gt 0 ] && {
echo "Failed to parse all passed arguments (unrecognized: \"$@\")"
exit 1
}
[ -n "${OUTPUT}" ] || OUTPUT=fitimage.its
[ -n "${VERSION}" ] || VERSION="Unknown"
[ -n "${ARCH}" ] || ARCH=arm
Expand Down

0 comments on commit b8bbac9

Please sign in to comment.