Skip to content

Commit

Permalink
ipq806x: ecw5410: drop GPIO based MDIO1 node
Browse files Browse the repository at this point in the history
It looks like this is a leftover before there was a proper MDIO driver.
Since both PHY-s are connected to the HW MDIO bus there is no reason for
this to exist anymore, especially since it uses the same pins as the HW
controller and has the pinmux for the set to "MDIO" so this worked by
pure luck as GPIO MDIO would probe first and override the HW driver.

Move the GMAC3 to simply use the same MDIO bus phandle.

Signed-off-by: Robert Marko <robert.marko@sartura.hr>
  • Loading branch information
robimarko authored and adschm committed Oct 31, 2021
1 parent 766d1d6 commit fa3646c
Showing 1 changed file with 10 additions and 19 deletions.
Expand Up @@ -34,7 +34,6 @@

aliases {
serial1 = &gsbi1_serial;
mdio-gpio0 = &mdio0;
ethernet0 = &gmac3;
ethernet1 = &gmac2;

Expand Down Expand Up @@ -293,26 +292,18 @@
};
};

&soc {
mdio1: mdio {
compatible = "virtual,mdio-gpio";
#address-cells = <1>;
#size-cells = <0>;

status = "okay";

pinctrl-0 = <&mdio0_pins>;
pinctrl-names = "default";
&mdio0 {
status = "okay";

gpios = <&qcom_pinmux 1 GPIO_ACTIVE_HIGH &qcom_pinmux 0 GPIO_ACTIVE_HIGH>;
pinctrl-0 = <&mdio0_pins>;
pinctrl-names = "default";

phy0: ethernet-phy@0 {
reg = <0>;
};
phy0: ethernet-phy@0 {
reg = <0>;
};

phy1: ethernet-phy@1 {
reg = <1>;
};
phy1: ethernet-phy@1 {
reg = <1>;
};
};

Expand All @@ -330,7 +321,7 @@
status = "okay";

qcom,id = <3>;
mdiobus = <&mdio1>;
mdiobus = <&mdio0>;

phy-mode = "sgmii";
phy-handle = <&phy0>;
Expand Down

0 comments on commit fa3646c

Please sign in to comment.