made it so if you have commit and no release - no dice

muschellij2 · Jun 15, 2017 · 0a74773 · 0a74773
1 parent 5f67b03
commit 0a74773
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: ghtravis
 Type: Package
 Title: Interfaces with GitHub API and Travis
-Version: 0.3.1
+Version: 0.3.2
 Author: John Muschelli
 Maintainer: John Muschelli <muschellij2@gmail.com>
 Description: Interfaces and compares things on 'GitHub'

diff --git a/R/latest_release_with_binary.R b/R/latest_release_with_binary.R
@@ -137,8 +137,14 @@ latest_release_with_binary = function(repo,
 
   ddf = df
   ddf = ddf[ grep(sys_ext(), ddf$asset_name, fixed = TRUE),]
-  if (ref %in% ddf$commit.sha) {
-    ddf = ddf[ ddf$commit.sha %in% ref, ]
+  if (!(ref %in% "master")) {
+    if (!(ref %in% ddf$commit.sha)) {
+      warning(paste0("SHA was given, but no release associated",
+                     " with it!, not installing, returning NA"))
+      return(NA)
+    } else {
+      ddf = ddf[ ddf$commit.sha %in% ref, ]
+    }
   }
   ord = order(ddf$asset_created_at, decreasing = TRUE)
   ddf = ddf[ord, ]