updated with warning

muschellij2 · Jun 15, 2017 · 1ca3d68 · 1ca3d68
1 parent 9d61987
commit 1ca3d68
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: ghtravis
 Type: Package
 Title: Interfaces with GitHub API and Travis
-Version: 0.2.9
+Version: 0.2.10
 Author: John Muschelli
 Maintainer: John Muschelli <muschellij2@gmail.com>
 Description: Interfaces and compares things on 'GitHub' 'API' and 'Travis' 'CI'.

diff --git a/R/install_remote_binaries.R b/R/install_remote_binaries.R
@@ -30,7 +30,7 @@ install_remote_binaries = function(
 
   urls = remote_binaries(path = path, remotes = remotes)
   if (!is.null(package)) {
-    if (package != "") {
+    if (all(package != "")) {
       urls = urls[intersect(package, names(urls))]
     }
   }
@@ -76,7 +76,15 @@ install_remote_binaries = function(
       # need to check versions!
       keep_packs = update_these_packages(path = path)
       # utils::remove.packages(keep_packs)
-      packs = packs[ !(packs %in% keep_packs)]
+      keep = (packs %in% keep_packs)
+      if (!all(keep)) {
+        warning(
+          paste0(
+            "Packages: ", paste(packs[keep_packs], collapse = ","),
+                "have installed binary, but version not correct!")
+        )
+      }
+      packs = packs[ !keep ]
     # }
 
     if (file.exists(path)) {