Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build with ninja 1.12.0, fix #1276 #1277

Merged
merged 2 commits into from
May 6, 2024
Merged

Fix build with ninja 1.12.0, fix #1276 #1277

merged 2 commits into from
May 6, 2024

Conversation

BSDKaffee
Copy link
Contributor

No description provided.

freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request May 6, 2024
@BSDKaffee
audio/muse-sequencer: ninja >= 1.12.0 build fix
26bc7a8 
Add pending upstreamed patch [1] to fix the build with ninja >= 1.12.0.

[1] muse-sequencer/muse#1277

PR:		278693
Approved by:	portmgr (blanket)
terminator356
terminator356 approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@terminator356 terminator356 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It appears that 'midisyncimpl.h' can also be removed,
and possibly a few other headers.

@terminator356 terminator356 merged commit a038ac2 into muse-sequencer:master May 6, 2024
@terminator356
Copy link
Member

We've had these build race conditions several times in the past,
sometimes requiring mind-bending extensive rewrites.
Been quiet for several years though.

Thanks very much for the PR and tracking the problem.
I will review the other headers and remove the one I mentioned and possibly some others.
Sometimes it's just old code that one way or another got lost in time.

@terminator356
Copy link
Member

OK I also removed 'ctrlcombo.h' and 'midisyncimpl.h'. Hope it don't break anything.
We're lucky these are simple fixes not requiring rewrites like other building race conditions we've had :-)

Try it out, let me know if any trouble.
Thanks.
Tim.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terminator356 terminator356 terminator356 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BSDKaffee @terminator356