More improvements

musescore · Jan 20, 2022 · 0a61d46 · 0a61d46
1 parent abd17b0
commit 0a61d46
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/engraving/layout/layoutsystem.cpp b/src/engraving/layout/layoutsystem.cpp
@@ -86,7 +86,7 @@ System* LayoutSystem::collectSystem(const LayoutOptions& options, LayoutContext&
     bool curTrailer = ctx.curMeasure->trailer();
     MeasureBase* breakMeasure = nullptr;
 
-    Fraction minTicks = Fraction(10000, 1); // Initializing this variable at a random high value.
+    Fraction minTicks = Fraction::max(); // Initializing this variable at an arbitrary high value.
     // In principle, it just needs to be longer than any possible note.
     Fraction prevMinTicks = Fraction(1, 1);
     bool changeMinSysTicks = false;

diff --git a/src/engraving/libmscore/system.cpp b/src/engraving/libmscore/system.cpp
@@ -1832,7 +1832,7 @@ int System::lastVisibleSysStaffOfPart(const Part* part) const
 
 Fraction System::minSysTicks() const
 {
-    Fraction minTicks = Fraction (10000, 1); // Initializing the variable at a random high value.
+    Fraction minTicks = Fraction::max(); // Initializing the variable at an arbitrary high value.
     // In principle, it just needs to be longer than any possible note, such that the following loop
     // always correctly returns the shortest note/rest of the system.
     for (MeasureBase* mb : measures()) {

diff --git a/src/engraving/types/fraction.h b/src/engraving/types/fraction.h
@@ -71,6 +71,9 @@ class Fraction
     int numerator() const { return m_numerator; }
     int denominator() const { return m_denominator; }
 
+    static constexpr Fraction max() { return Fraction(10000, 1); }
+    // Use this when you need to initialize a Fraction to an arbitrary high value
+
     void setNumerator(int v) { m_numerator = v; }
     void setDenominator(int v)
     {