fix #24732: update Style for part in prefs dialog

musescore · Feb 19, 2014 · 0aba0eb · 0aba0eb
1 parent b3461e9
commit 0aba0eb
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/libmscore/mscore.cpp b/libmscore/mscore.cpp
@@ -190,6 +190,7 @@ MStyle* MScore::defaultStyle()
 
 MStyle* MScore::defaultStyleForParts()
       {
+#if 0
       if (!_defaultStyleForParts) {
             QSettings s;
             QString partStyle = s.value("partStyle").toString();
@@ -204,6 +205,7 @@ MStyle* MScore::defaultStyleForParts()
                         }
                   }
             }
+#endif
       return _defaultStyleForParts;
       }
 

diff --git a/libmscore/score.cpp b/libmscore/score.cpp
@@ -378,15 +378,25 @@ Score::Score(Score* parent)
       _parentScore = parent;
       init();
 
+      // inherit most style settings from parent
       _style = *parent->style();
 
+      // style inheritance overrides
       QSettings s;
       QString partStyle = s.value("partStyle").toString();
       if (!partStyle.isEmpty()) {
+            // allow "Style for part" preference to override
             QFile f(partStyle);
             if (f.open(QIODevice::ReadOnly))
                   _style.load(&f);
             }
+      else {
+            // allow defaultStyle page layout settings to override
+            const PageFormat* pf = MScore::defaultStyle()->pageFormat();
+            qreal sp = MScore::defaultStyle()->spatium();
+            _style.setPageFormat(*pf);
+            _style.setSpatium(sp);
+            }
 
       _synthesizerState = parent->_synthesizerState;
       }

diff --git a/mscore/preferences.cpp b/mscore/preferences.cpp
@@ -989,6 +989,8 @@ void PreferenceDialog::updateValues()
       animations->setChecked(prefs.animations);
 
       defaultStyle->setText(prefs.defaultStyleFile);
+      QSettings s;
+      partStyle->setText(s.value("partStyle").toString());
 
       myScores->setText(prefs.myScoresPath);
       myStyles->setText(prefs.myStylesPath);