Skip to content

Commit

Permalink
fix #111346: initial implementation of playback of graceNotesAfter
Browse files Browse the repository at this point in the history
  creating function graceNotesMerged
  this entailed refactoring several data structure to make them visible globally.
  used function graceNotesMerged to avoid duplicating grace notes if they are played by trill code.
  added handing of play=false for grace note midi rendering
  added test cases
  updated test cases because of recent metronome changes on master
  • Loading branch information
jimka2001 committed Aug 10, 2016
1 parent f3a711f commit 10ecb8b
Show file tree
Hide file tree
Showing 7 changed files with 1,675 additions and 145 deletions.
425 changes: 281 additions & 144 deletions libmscore/rendermidi.cpp

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion libmscore/score.h
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ class Score : public QObject, public ScoreElement {
SynthesizerState _synthesizerState;

void createPlayEvents(Chord*);
void createGraceNotesPlayEvents(QVector<Chord*> gnb, int tick, Chord* chord, int& ontime);
void createGraceNotesPlayEvents(int tick, Chord* chord, int& ontime, int& trailtime);

signals:
void posChanged(POS, unsigned);
Expand Down
202 changes: 202 additions & 0 deletions mtest/libmscore/midi/testBeforeAfterGraceTrill-ref.txt

Large diffs are not rendered by default.

Loading

0 comments on commit 10ecb8b

Please sign in to comment.