Skip to content

Commit

Permalink
Merge pull request #17449 from mikekirin/import-gp5-bends-harmcs-fix
Browse files Browse the repository at this point in the history
Harmonics now plays bends for gp5 files
  • Loading branch information
mikekirin committed May 3, 2023
2 parents efa8b51 + 29e1cb5 commit 133e5bf
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/importexport/guitarpro/internal/importgtp-gp5.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1013,8 +1013,10 @@ bool GuitarPro5::readNoteEffects(Note* note)
uint8_t modMask1 = readUInt8();
uint8_t modMask2 = readUInt8();
bool slur = false;
bool addBendToHarmonic = false;

if (modMask1 & EFFECT_BEND) {
addBendToHarmonic = true;
readBend(note);
}
if (modMask1 & EFFECT_HAMMER) {
Expand Down Expand Up @@ -1274,6 +1276,10 @@ bool GuitarPro5::readNoteEffects(Note* note)
}

addTextToNote(harmonicText, harmonicNote);

if (addBendToHarmonic) {
harmonicNote->add(note->bend()->clone());
}
}
}

Expand Down

0 comments on commit 133e5bf

Please sign in to comment.