Fix #105646: Create album of continuous-view scores crashes

musescore · Feb 19, 2018 · 2051d6a · 2051d6a
1 parent ae2b690
commit 2051d6a
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/mscore/album.cpp b/mscore/album.cpp
@@ -147,6 +147,9 @@ bool Album::createScore(const QString& fn, bool addPageBreak, bool addSectionBre
             return false;
             }
 
+      LayoutMode layoutMode = firstScore->layoutMode();
+      firstScore->switchToPageMode();
+
       // do layout for first score's root and excerpt scores
       firstScore->doLayout();
       for (int i = 0; i < firstScore->excerpts().count(); i++) {
@@ -163,7 +166,7 @@ bool Album::createScore(const QString& fn, bool addPageBreak, bool addSectionBre
 
       int excerptCount = firstScore->excerpts().count();
       bool joinExcerpt = true;
-	for (AlbumItem* item : _scores) {
+      for (AlbumItem* item : _scores) {
             if (item->score == 0 || item->score == firstScore)
                   continue;
             if (item->score->excerpts().count() != excerptCount) {
@@ -183,6 +186,7 @@ bool Album::createScore(const QString& fn, bool addPageBreak, bool addSectionBre
                   continue;
 
             // try to append root score
+            item->score->ScoreElement::undoChangeProperty(P_ID::LAYOUT_MODE, int(LayoutMode::PAGE));
             item->score->doLayout();
             if (!score->appendScore(item->score, addPageBreak, addSectionBreak)) {
                   qDebug("Cannot append root score of album item \"%s\".", qPrintable(item->name));
@@ -212,6 +216,8 @@ bool Album::createScore(const QString& fn, bool addPageBreak, bool addSectionBre
                   }
             }
 
+      if (layoutMode != firstScore->layoutMode())
+            firstScore->endCmd(true);       // rollback
       score->fileInfo()->setFile(fn);
       qDebug("Album::createScore: save file");
       try {