Skip to content

Commit

Permalink
Don't have strings in plugins translatable that [dw]on't work anyhow
Browse files Browse the repository at this point in the history
The plugin description and -path are not shown translated even if they
are (like for the helloqml plugin and German).
Showing as being translatable gives a wrong impression as examples for
other plugins.
  • Loading branch information
Jojo-Schmitz committed Sep 1, 2021
1 parent 5e3a729 commit 266fb85
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 12 deletions.
2 changes: 1 addition & 1 deletion share/plugins/abc_import.qml
Expand Up @@ -29,7 +29,7 @@ import FileIO 3.0
MuseScore {
menuPath: "Plugins.ABC Import"
version: "3.0"
description: qsTr("This plugin imports ABC text from a file or the clipboard. Internet connection is required.")
description: "This plugin imports ABC text from a file or the clipboard. Internet connection is required."
requiresScore: false
pluginType: "dialog"

Expand Down
2 changes: 1 addition & 1 deletion share/plugins/colornotes.qml
Expand Up @@ -25,7 +25,7 @@ import MuseScore 3.0

MuseScore {
version: "3.5"
description: qsTr("This plugin colors notes in the selection depending on their pitch as per the Boomwhackers convention")
description: "This plugin colors notes in the selection depending on their pitch as per the Boomwhackers convention"
menuPath: "Plugins.Notes.Color Notes"

property variant colors : [ // "#rrggbb" with rr, gg, and bb being the hex values for red, green, and blue, respectively
Expand Down
2 changes: 1 addition & 1 deletion share/plugins/helloqml/helloqml.qml
Expand Up @@ -26,7 +26,7 @@ import MuseScore 3.0
MuseScore {
menuPath: "Plugins.helloQml"
version: "3.0"
description: qsTr("This demo plugin shows some basic tasks.")
description: "This demo plugin shows some basic tasks."
pluginType: "dialog"

width: 150
Expand Down
Binary file modified share/plugins/helloqml/translations/locale_de.qm
Binary file not shown.
5 changes: 0 additions & 5 deletions share/plugins/helloqml/translations/locale_de.ts
Expand Up @@ -3,11 +3,6 @@
<TS version="2.0" language="de_DE">
<context>
<name>helloqml</name>
<message>
<location filename="../helloqml.qml" line="8"/>
<source>This demo plugin shows some basic tasks.</source>
<translation>Dieses Demo-Plugin zeigt einige einfache Funktionen.</translation>
</message>
<message>
<location filename="../helloqml.qml" line="13"/>
<source>hello world</source>
Expand Down
4 changes: 2 additions & 2 deletions share/plugins/notenames-interactive.qml
Expand Up @@ -26,8 +26,8 @@ import MuseScore 3.0

MuseScore {
version: "3.5"
description: qsTr("This plugin names notes as per your language setting")
menuPath: "Plugins.Notes." + qsTr("Note Names (Interactive)")
description: "This plugin names notes as per your language setting"
menuPath: "Plugins.Notes." + "Note Names (Interactive)"
pluginType: "dock"

implicitHeight: controls.implicitHeight * 1.5
Expand Down
4 changes: 2 additions & 2 deletions share/plugins/notenames.qml
Expand Up @@ -25,8 +25,8 @@ import MuseScore 3.0

MuseScore {
version: "3.5"
description: qsTr("This plugin names notes as per your language setting")
menuPath: "Plugins.Notes." + qsTr("Note Names")
description: "This plugin names notes as per your language setting"
menuPath: "Plugins.Notes." + "Note Names"

// Small note name size is fraction of the full font size.
property var fontSizeMini: 0.7;
Expand Down

0 comments on commit 266fb85

Please sign in to comment.