Merge pull request #11434 from poypoyan/helpmenu

fix #11415: Help Menu - Ordering
musescore · Apr 27, 2022 · 3392b39 · 3392b39
2 parents a961033 + 06da581
commit 3392b39
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/src/appshell/view/appmenumodel.cpp b/src/appshell/view/appmenumodel.cpp
@@ -321,22 +321,23 @@ MenuItem* AppMenuModel::makeHelpMenu()
     MenuItemList helpItems {
         makeMenuItem("online-handbook"),
         makeSeparator(),
+        makeMenuItem("ask-help"),
+        makeMenuItem("report-bug"),
+        makeMenuItem("leave-feedback"),
+        makeSeparator(),
         makeMenuItem("about", MenuItemRole::AboutRole),
         makeMenuItem("about-qt", MenuItemRole::AboutQtRole),
-        makeMenuItem("about-musicxml")
+        makeMenuItem("about-musicxml"),
+        makeSeparator(),
+        makeMenuItem("revert-factory")
     };
 
+    // put on top
     if (configuration()->isAppUpdatable()) {
-        helpItems << makeMenuItem("check-update");
+        helpItems.push_front(makeSeparator());
+        helpItems.push_front(makeMenuItem("check-update"));
     }
 
-    helpItems << makeSeparator()
-              << makeMenuItem("ask-help")
-              << makeMenuItem("report-bug")
-              << makeMenuItem("leave-feedback")
-              << makeSeparator()
-              << makeMenuItem("revert-factory");
-
     return makeMenu(qtrc("appshell", "&Help"), helpItems, "menu-help");
 }