Skip to content

Commit

Permalink
Code review fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
cbjeukendrup committed Oct 28, 2023
1 parent bacf905 commit 341efb1
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 6 deletions.
1 change: 0 additions & 1 deletion src/engraving/dom/keysig.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@
#include "masterscore.h"
#include "score.h"
#include "segment.h"
#include "system.h"
#include "staff.h"
#include "part.h"

Expand Down
1 change: 0 additions & 1 deletion src/engraving/dom/transpose.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#include "segment.h"
#include "staff.h"
#include "stafftype.h"
#include "system.h"
#include "undo.h"
#include "utils.h"

Expand Down
5 changes: 3 additions & 2 deletions src/engraving/dom/utils.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
#include "chord.h"
#include "chordrest.h"
#include "clef.h"
#include "keysig.h"
#include "measure.h"
#include "note.h"
#include "page.h"
Expand Down Expand Up @@ -1340,10 +1341,10 @@ bool isFirstSystemKeySig(const KeySig* ks)
if (!ks) {
return false;
}
System* sys = ks->measure()->system();
const System* sys = ks->measure()->system();
if (!sys) {
return false;
}
return ks->tick().ticks() == sys->firstMeasure()->tick().ticks();
return ks->tick() == sys->firstMeasure()->tick();
}
}
4 changes: 2 additions & 2 deletions src/engraving/dom/utils.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,18 +26,18 @@
#include "types/types.h"

#include "interval.h"
#include "keysig.h"

#include "draw/types/geometry.h"

namespace mu::engraving {
class Chord;
class EngravingItem;
class KeySig;
class Note;
class Rest;
class Segment;
class System;
class Tuplet;
class EngravingItem;

enum class Key;

Expand Down

0 comments on commit 341efb1

Please sign in to comment.