Skip to content

Commit

Permalink
fix #276973: assertion failure when entering figured bass
Browse files Browse the repository at this point in the history
  • Loading branch information
jthistle committed Nov 5, 2018
1 parent c071ad3 commit 6193db8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
1 change: 0 additions & 1 deletion libmscore/textbase.cpp
Expand Up @@ -2450,7 +2450,6 @@ void TextBase::initTid(Tid tid, bool preserveDifferent)
initTid(tid);
else {
setTid(tid);
qDebug("preserving different");
for (const StyledProperty& p : *textStyle(tid)) {
if (getProperty(p.pid) == propertyDefault(p.pid))
setProperty(p.pid, styleValue(p.pid, p.sid));
Expand Down
5 changes: 3 additions & 2 deletions mscore/editfiguredbass.cpp
Expand Up @@ -98,17 +98,18 @@ void ScoreView::figuredBassTab(bool bMeas, bool bBack)

changeState(ViewState::NORMAL);

_score->startCmd();
bool bNew;
// add a (new) FB element, using chord duration as default duration
FiguredBass * fbNew = FiguredBass::addFiguredBassToSegment(nextSegm, track, 0, &bNew);
if (bNew)
_score->undoAddElement(fbNew);
_score->select(fbNew, SelectType::SINGLE, 0);
startEdit(fbNew, Grip::NO_GRIP);

_score->startCmd();
mscore->changeState(mscoreState());
adjustCanvasPosition(fbNew, false);
//TODO-edit ((FiguredBass*)editData.element)->moveCursorToEnd();
fbNew->cursor(editData)->moveCursorToEnd();
// _score->update(); // used by lyricsTab() but not by harmonyTab(): needed or not?
}

Expand Down

0 comments on commit 6193db8

Please sign in to comment.