Skip to content

Commit

Permalink
fix #181341: Selecting accidentals by voice doesn't work
Browse files Browse the repository at this point in the history
  • Loading branch information
Jojo-Schmitz committed Mar 14, 2017
1 parent 3e52608 commit 6db744d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion libmscore/score.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3065,7 +3065,7 @@ void Score::collectMatch(void* data, Element* e)
&& ((p->staffStart > e->staffIdx()) || (p->staffEnd <= e->staffIdx())))
return;
if (e->type() == Element::Type::CHORD || e->type() == Element::Type::REST
|| e->type() == Element::Type::ARTICULATION || e->type() == Element::Type::LYRICS
|| e->type() == Element::Type::ARTICULATION | e->type() == Element::Type::ACCIDENTAL || e->type() == Element::Type::LYRICS
|| e->type() == Element::Type::BEAM || e->type() == Element::Type::HOOK || e->type() == Element::Type::STEM
|| e->type() == Element::Type::SLUR_SEGMENT || e->type() == Element::Type::NOTEDOT
|| e->type() == Element::Type::FINGERING || e->type() == Element::Type::TUPLET) {
Expand Down

4 comments on commit 6db744d

@MarcSabatella
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure you meant "||", not "|", between the ARTICULATION and ACCIDENTAL check.

@Jojo-Schmitz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yes, of course

@lasconic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in ca22d7a

@Jojo-Schmitz
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Please sign in to comment.