Skip to content

Commit

Permalink
fix #68151, fix #68856, fix #97796, fix #97821, fix #112291: save/res…
Browse files Browse the repository at this point in the history
…tore geometry
  • Loading branch information
jeetee committed Jul 30, 2016
1 parent 8c79698 commit d2bf3b8
Show file tree
Hide file tree
Showing 15 changed files with 105 additions and 3 deletions.
15 changes: 15 additions & 0 deletions mscore/editpitch.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
//=============================================================================

#include "editpitch.h"
#include "musescore.h"

namespace Ms {

Expand All @@ -30,24 +31,38 @@ namespace Ms {
EditPitch::EditPitch(QWidget *parent)
: QDialog(parent)
{
setObjectName("EditPitchNew");
setupUi(this);
setWindowFlags(this->windowFlags() & ~Qt::WindowContextHelpButtonHint);
tableWidget->setCurrentCell(4, 0); // select centre C by default
MuseScore::restoreGeometry(this);
}

EditPitch::EditPitch(QWidget *parent, int midiCode)
: QDialog(parent)
{
setObjectName("EditPitchEdit");
setupUi(this);
setWindowFlags(this->windowFlags() & ~Qt::WindowContextHelpButtonHint);
tableWidget->setCurrentCell(9-(midiCode/12), midiCode%12);
MuseScore::restoreGeometry(this);
}

EditPitch::~EditPitch()
{

}

//---------------------------------------------------------
// hideEvent
//---------------------------------------------------------

void EditPitch::hideEvent(QHideEvent* ev)
{
MuseScore::saveGeometry(this);
QWidget::hideEvent(ev);
}

void EditPitch::accept()
{
int col = tableWidget->currentColumn();
Expand Down
2 changes: 2 additions & 0 deletions mscore/editpitch.h
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ namespace Ms {
class EditPitch : public QDialog, private Ui::EditPitchBase {
Q_OBJECT

virtual void hideEvent(QHideEvent*);

private slots:
void on_tableWidget_cellDoubleClicked(int row, int column);
void accept();
Expand Down
13 changes: 13 additions & 0 deletions mscore/editstafftype.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ const char* g_groupNames[STAFF_GROUP_MAX] = {
EditStaffType::EditStaffType(QWidget* parent, Staff* st)
: QDialog(parent)
{
setObjectName("EditStaffType");
setWindowFlags(this->windowFlags() & ~Qt::WindowContextHelpButtonHint);
setupUi(this);

Expand Down Expand Up @@ -123,6 +124,18 @@ EditStaffType::EditStaffType(QWidget* parent, Staff* st)
connect(templateReset, SIGNAL(clicked()), SLOT(resetToTemplateClicked()));
connect(addToTemplates, SIGNAL(clicked()), SLOT(addToTemplatesClicked()));
// connect(groupCombo, SIGNAL(currentIndexChanged(int)), SLOT(staffGroupChanged(int)));

MuseScore::restoreGeometry(this);
}

//---------------------------------------------------------
// hideEvent
//---------------------------------------------------------

void EditStaffType::hideEvent(QHideEvent* ev)
{
MuseScore::saveGeometry(this);
QWidget::hideEvent(ev);
}

//---------------------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions mscore/editstafftype.h
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ class EditStaffType : public QDialog, private Ui::EditStaffType {
Staff* staff;
StaffType staffType;

virtual void hideEvent(QHideEvent *);
void blockSignals(bool block);

void setFromDlg();
Expand Down
14 changes: 14 additions & 0 deletions mscore/editstringdata.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@

#include "editstringdata.h"
#include "editpitch.h"
#include "musescore.h"

namespace Ms {

Expand All @@ -31,6 +32,7 @@ namespace Ms {
EditStringData::EditStringData(QWidget *parent, QList<instrString> * strings, int * frets)
: QDialog(parent)
{
setObjectName("EditStringData");
setupUi(this);
setWindowFlags(this->windowFlags() & ~Qt::WindowContextHelpButtonHint);
_strings = strings;
Expand Down Expand Up @@ -73,12 +75,24 @@ EditStringData::EditStringData(QWidget *parent, QList<instrString> * strings, in
connect(stringList, SIGNAL(doubleClicked(QModelIndex)), SLOT(editStringClicked()));
connect(stringList, SIGNAL(itemClicked(QTableWidgetItem*)), SLOT(listItemClicked(QTableWidgetItem *)));
_modified = false;

MuseScore::restoreGeometry(this);
}

EditStringData::~EditStringData()
{
}

//---------------------------------------------------------
// hideEvent
//---------------------------------------------------------

void EditStringData::hideEvent(QHideEvent* ev)
{
MuseScore::saveGeometry(this);
QWidget::hideEvent(ev);
}

//---------------------------------------------------------
// deleteStringClicked
//---------------------------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions mscore/editstringdata.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ class EditStringData : public QDialog, private Ui::EditStringDataBase {
QList<instrString>* _strings; // pointer to original string list
QList<instrString> _stringsLoc; // local working copy of string list

virtual void hideEvent(QHideEvent*);

public:
EditStringData(QWidget *parent, QList<instrString> * strings, int * frets);
~EditStringData();
Expand Down
13 changes: 12 additions & 1 deletion mscore/editstyle.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ namespace Ms {
EditStyle::EditStyle(Score* s, QWidget* parent)
: QDialog(parent)
{
setObjectName("EditStyle");
setupUi(this);
setWindowFlags(this->windowFlags() & ~Qt::WindowContextHelpButtonHint);
cs = s;
Expand Down Expand Up @@ -434,10 +435,20 @@ EditStyle::EditStyle(Score* s, QWidget* parent)
connect(mapper, SIGNAL(mapped(int)), SLOT(resetStyleValue(int)));
connect(mapper2, SIGNAL(mapped(int)), SLOT(valueChanged(int)));

resize(904, 577); // override designer values
MuseScore::restoreGeometry(this);
cs->startCmd();
}

//---------------------------------------------------------
// closeEvent
//---------------------------------------------------------

void EditStyle::hideEvent(QHideEvent* ev)
{
MuseScore::saveGeometry(this);
QWidget::hideEvent(ev);
}

//---------------------------------------------------------
// buttonClicked
//---------------------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions mscore/editstyle.h
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ class EditStyle : public QDialog, private Ui::EditStyleBase {
QVector<StyleWidget> styleWidgets;
QSignalMapper* anchorMapper;

virtual void hideEvent(QHideEvent*);
QVariant getValue(StyleIdx idx);
// void getValues();
void setValues();
Expand Down
4 changes: 2 additions & 2 deletions mscore/editstyle.ui
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
<rect>
<x>0</x>
<y>0</y>
<width>1125</width>
<height>865</height>
<width>904</width>
<height>580</height>
</rect>
</property>
<property name="windowTitle">
Expand Down
14 changes: 14 additions & 0 deletions mscore/pagesettings.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ namespace Ms {
PageSettings::PageSettings(QWidget* parent)
: AbstractDialog(parent)
{
setObjectName("PageSettings");
setupUi(this);
setWindowFlags(this->windowFlags() & ~Qt::WindowContextHelpButtonHint);
setModal(true);
Expand All @@ -53,6 +54,9 @@ PageSettings::PageSettings(QWidget* parent)
mmButton->setChecked(true);
else
inchButton->setChecked(true);

MuseScore::restoreGeometry(this);

connect(mmButton, SIGNAL(clicked()), SLOT(mmClicked()));
connect(inchButton, SIGNAL(clicked()), SLOT(inchClicked()));
connect(buttonApply, SIGNAL(clicked()), SLOT(apply()));
Expand Down Expand Up @@ -83,6 +87,16 @@ PageSettings::~PageSettings()
{
}

//---------------------------------------------------------
// hideEvent
//---------------------------------------------------------

void PageSettings::hideEvent(QHideEvent* ev)
{
MuseScore::saveGeometry(this);
QWidget::hideEvent(ev);
}

//---------------------------------------------------------
// setScore
//---------------------------------------------------------
Expand Down
2 changes: 2 additions & 0 deletions mscore/pagesettings.h
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ class PageSettings : public AbstractDialog, private Ui::PageSettingsBase {
Navigator* preview;
bool mmUnit;
MasterScore* cs;

virtual void hideEvent(QHideEvent*);
void updateValues();
void updatePreview(int);
void blockSignals(bool);
Expand Down
13 changes: 13 additions & 0 deletions mscore/preferences.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -539,6 +539,7 @@ void MuseScore::startPreferenceDialog()
PreferenceDialog::PreferenceDialog(QWidget* parent)
: AbstractDialog(parent)
{
setObjectName("PreferenceDialog");
setupUi(this);
setWindowFlags(this->windowFlags() & ~Qt::WindowContextHelpButtonHint);
setModal(true);
Expand Down Expand Up @@ -637,6 +638,8 @@ PreferenceDialog::PreferenceDialog(QWidget* parent)
connect(useJackAudio, SIGNAL(toggled(bool)), SLOT(nonExclusiveJackDriver(bool)));
connect(useJackMidi, SIGNAL(toggled(bool)), SLOT(nonExclusiveJackDriver(bool)));
updateRemote();

MuseScore::restoreGeometry(this);
}

//---------------------------------------------------------
Expand All @@ -658,6 +661,16 @@ PreferenceDialog::~PreferenceDialog()
qDeleteAll(localShortcuts);
}

//---------------------------------------------------------
// hideEvent
//---------------------------------------------------------

void PreferenceDialog::hideEvent(QHideEvent* ev)
{
MuseScore::saveGeometry(this);
QWidget::hideEvent(ev);
}

//---------------------------------------------------------
// recordButtonClicked
//---------------------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions mscore/prefsdialog.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ class PreferenceDialog : public AbstractDialog, private Ui::PrefsDialogBase {
QButtonGroup* recordButtons;
Preferences prefs;

virtual void hideEvent(QHideEvent*);
void apply();
void updateSCListView();
void setUseMidiOutput(bool);
Expand Down
12 changes: 12 additions & 0 deletions mscore/textpalette.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -540,6 +540,7 @@ const QStringList unicodeRangeNames = {
TextPalette::TextPalette(QWidget* parent)
: QWidget(parent)
{
setObjectName("TextPalette");
setWindowFlags(Qt::Tool);
setupUi(this);

Expand Down Expand Up @@ -604,6 +605,7 @@ TextPalette::TextPalette(QWidget* parent)
populateSmufl();

setFocusPolicy(Qt::NoFocus);
MuseScore::restoreGeometry(this);
}

//---------------------------------------------------------
Expand Down Expand Up @@ -837,6 +839,16 @@ void TextPalette::setText(Text* te)
_textElement = te;
}

//---------------------------------------------------------
// hideEvent
//---------------------------------------------------------

void TextPalette::hideEvent(QHideEvent* ev)
{
MuseScore::saveGeometry(this);
QWidget::hideEvent(ev);
}

//---------------------------------------------------------
// closeEvent
//---------------------------------------------------------
Expand Down
1 change: 1 addition & 0 deletions mscore/textpalette.h
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ class TextPalette : public QWidget, public Ui::TextPaletteBase {
QListWidget* lws;
QListWidget* lwu;

virtual void hideEvent(QHideEvent*);
void closeEvent(QCloseEvent* ev);
void populateCommon();

Expand Down

0 comments on commit d2bf3b8

Please sign in to comment.