Skip to content

Commit

Permalink
"Double Coda" to "Codetta"
Browse files Browse the repository at this point in the history
as it was known under in MuseScore 1's repeats palette, and in Mu3' and Mu4'S timeline
  • Loading branch information
Jojo-Schmitz committed Sep 4, 2023
1 parent bb4d41c commit d68c996
Show file tree
Hide file tree
Showing 11 changed files with 32 additions and 32 deletions.
12 changes: 6 additions & 6 deletions src/engraving/dom/jump.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ const std::vector<JumpTypeTableItem> jumpTypeTable {
{ JumpType::DS_AL_FINE, "D.S. al Fine", "segno", "fine", "" },
{ JumpType::DS, "D.S.", "segno", "end", "" },

{ JumpType::DC_AL_DBLCODA, "D.C. al Double Coda", "start", "varcoda", "codab" },
{ JumpType::DS_AL_DBLCODA, "D.S. al Double Coda", "segno", "varcoda", "codab" },
{ JumpType::DSS, "Dal Segno Segno", "varsegno", "end", "" },
{ JumpType::DSS_AL_CODA, "D.S.S. al Coda", "varsegno", "coda", "codab" },
{ JumpType::DSS_AL_DBLCODA, "D.S.S. al Double Coda", "varsegno", "varcoda", "codab" },
{ JumpType::DSS_AL_FINE, "D.S.S. al Fine", "varsegno", "fine", "" },
{ JumpType::DC_AL_DBLCODA, "D.C. al Codetta", "start", "varcoda", "codab" },
{ JumpType::DS_AL_DBLCODA, "D.S. al Codetta", "segno", "varcoda", "codab" },
{ JumpType::DSS, "Dal Segno Segno", "varsegno", "end", "" },
{ JumpType::DSS_AL_CODA, "D.S.S. al Coda", "varsegno", "coda", "codab" },
{ JumpType::DSS_AL_DBLCODA, "D.S.S. al Codetta", "varsegno", "varcoda", "codab" },
{ JumpType::DSS_AL_FINE, "D.S.S. al Fine", "varsegno", "fine", "" },
};

//---------------------------------------------------------
Expand Down
2 changes: 1 addition & 1 deletion src/engraving/dom/marker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ void Marker::setMarkerType(MarkerType t)
break;

case MarkerType::DA_DBLCODA:
txt = "Da Double Coda";
txt = "Da Codetta";
initTextStyleType(TextStyleType::REPEAT_RIGHT, true);
setLabel(u"coda");
break;
Expand Down
2 changes: 1 addition & 1 deletion src/engraving/tests/repeat_tests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ TEST_F(Engraving_RepeatTests, repeat46) {
}

TEST_F(Engraving_RepeatTests, repeat47) {
// #269378 Double Coda messed up repeat rewind logic
// #269378 Double Coda AKA Codetta messed up repeat rewind logic
repeat("repeat47.mscx", u"1;2;3; 2; 4;5;6;7; 6; 8;9;10;11; 2; 4; 13;14;15; 9;10; 16;17;18");
}

Expand Down
8 changes: 4 additions & 4 deletions src/engraving/types/typesconv.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -2271,11 +2271,11 @@ static const std::vector<Item<JumpType> > JUMP_TYPES = {
{ JumpType::DS_AL_FINE, "", TranslatableString("engraving", "D.S. al Fine") },
{ JumpType::DS, "", TranslatableString("engraving", "D.S.") },

{ JumpType::DC_AL_DBLCODA, "", TranslatableString("engraving", "Da Capo al Double Coda") },
{ JumpType::DS_AL_DBLCODA, "", TranslatableString("engraving", "Dal Segno al Double Coda") },
{ JumpType::DC_AL_DBLCODA, "", TranslatableString("engraving", "Da Capo al Codetta") },
{ JumpType::DS_AL_DBLCODA, "", TranslatableString("engraving", "Dal Segno al Codetta") },
{ JumpType::DSS, "", TranslatableString("engraving", "Dal Segno Segno") },
{ JumpType::DSS_AL_CODA, "", TranslatableString("engraving", "Dal Segno Segno al Coda") },
{ JumpType::DSS_AL_DBLCODA, "", TranslatableString("engraving", "Dal Segno Segno al Double Coda") },
{ JumpType::DSS_AL_DBLCODA, "", TranslatableString("engraving", "Dal Segno Segno al Codetta") },
{ JumpType::DSS_AL_FINE, "", TranslatableString("engraving", "Dal Segno Segno al Fine") },

{ JumpType::USER, "", TranslatableString("engraving", "Custom") }
Expand All @@ -2301,7 +2301,7 @@ static const std::array<Item<MarkerType>, 11> MARKER_TYPES = { {
{ MarkerType::TOCODA, "coda", TranslatableString("engraving", "To coda") },
{ MarkerType::TOCODASYM, "", TranslatableString("engraving", "To coda (symbol)") },
{ MarkerType::DA_CODA, "", TranslatableString("engraving", "Da Coda") },
{ MarkerType::DA_DBLCODA, "", TranslatableString("engraving", "Da Double Coda") },
{ MarkerType::DA_DBLCODA, "", TranslatableString("engraving", "Da Codetta") },
{ MarkerType::USER, "", TranslatableString("engraving", "Custom") }
} };

Expand Down
8 changes: 4 additions & 4 deletions src/importexport/guitarpro/internal/importgtp-gp5.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1044,10 +1044,10 @@ bool GuitarPro5::read(IODevice* io)
Segment* s = measure->getSegment(SegmentType::KeySig, measure->tick());
StaffText* st = new StaffText(s);
static constexpr char text[][22] = {
"fine", "Da Capo", "D.C. al Coda", "D.C. al Double Coda",
"D.C. al Fine", "Da Segno", "D.S. al Coda", "D.S. al Double Coda",
"D.S. al Fine", "Da Segno Segno", "D.S.S. al Coda", "D.S.S. al Double Coda",
"D.S.S. al Fine", "Da Coda", "Da Double Coda"
"fine", "Da Capo", "D.C. al Coda", "D.C. al Codetta",
"D.C. al Fine", "Da Segno", "D.S. al Coda", "D.S. al Codetta",
"D.S. al Fine", "Da Segno Segno", "D.S.S. al Coda", "D.S.S. al Codetta",
"D.S.S. al Fine", "Da Coda", "Da Codetta"
};
st->setPlainText(String::fromAscii(text[i - 4]));
st->setParent(s);
Expand Down
8 changes: 4 additions & 4 deletions src/importexport/guitarpro/tests/data/directions.gp-ref.mscx
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
<Measure>
<Jump>
<style>repeat_right</style>
<text>D.C. al Double Coda</text>
<text>D.C. al Codetta</text>
<jumpTo>start</jumpTo>
<playUntil>varcoda</playUntil>
<continueAt>codab</continueAt>
Expand Down Expand Up @@ -300,7 +300,7 @@
<Measure>
<Jump>
<style>repeat_right</style>
<text>D.S. al Double Coda</text>
<text>D.S. al Codetta</text>
<jumpTo>segno</jumpTo>
<playUntil>varcoda</playUntil>
<continueAt>codab</continueAt>
Expand Down Expand Up @@ -428,7 +428,7 @@
<Measure>
<Jump>
<style>repeat_right</style>
<text>D.S.S. al Double Coda</text>
<text>D.S.S. al Codetta</text>
<jumpTo>varsegno</jumpTo>
<playUntil>varcoda</playUntil>
<continueAt>codab</continueAt>
Expand Down Expand Up @@ -517,7 +517,7 @@
<Measure>
<Marker>
<style>repeat_right</style>
<text>Da Double Coda</text>
<text>Da Codetta</text>
<label>coda</label>
</Marker>
<voice>
Expand Down
8 changes: 4 additions & 4 deletions src/importexport/guitarpro/tests/data/directions.gpx-ref.mscx
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@
<Measure>
<Jump>
<style>repeat_right</style>
<text>D.C. al Double Coda</text>
<text>D.C. al Codetta</text>
<jumpTo>start</jumpTo>
<playUntil>varcoda</playUntil>
<continueAt>codab</continueAt>
Expand Down Expand Up @@ -300,7 +300,7 @@
<Measure>
<Jump>
<style>repeat_right</style>
<text>D.S. al Double Coda</text>
<text>D.S. al Codetta</text>
<jumpTo>segno</jumpTo>
<playUntil>varcoda</playUntil>
<continueAt>codab</continueAt>
Expand Down Expand Up @@ -428,7 +428,7 @@
<Measure>
<Jump>
<style>repeat_right</style>
<text>D.S.S. al Double Coda</text>
<text>D.S.S. al Codetta</text>
<jumpTo>varsegno</jumpTo>
<playUntil>varcoda</playUntil>
<continueAt>codab</continueAt>
Expand Down Expand Up @@ -517,7 +517,7 @@
<Measure>
<Marker>
<style>repeat_right</style>
<text>Da Double Coda</text>
<text>Da Codetta</text>
<label>coda</label>
</Marker>
<voice>
Expand Down
2 changes: 1 addition & 1 deletion src/importexport/mei/tests/data/jump-01.mei
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
<note xml:id="n912k7" dur="1" pname="d" oct="4" />
</layer>
</staff>
<repeatMark xml:id="r1275fyx" type="mscore-jump-dc-al-double-coda" func="daCapo" tstamp="0.000000">D.C. al Double Coda</repeatMark>
<repeatMark xml:id="r1275fyx" type="mscore-jump-dc-al-double-coda" func="daCapo" tstamp="0.000000">D.C. al Codetta</repeatMark>
</measure>
<measure xml:id="m19nftig" n="3">
<staff xml:id="m3s1" n="1">
Expand Down
2 changes: 1 addition & 1 deletion src/importexport/mei/tests/data/jump-01.mscx
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
<Measure>
<Jump>
<style>repeat_right</style>
<text>D.C. al Double Coda</text>
<text>D.C. al Codetta</text>
<jumpTo>start</jumpTo>
<playUntil>varcoda</playUntil>
<continueAt>codab</continueAt>
Expand Down
6 changes: 3 additions & 3 deletions src/importexport/mei/tests/data/jump-02.mei
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@
<mRest xml:id="mf88e0i" />
</layer>
</staff>
<repeatMark xml:id="rb0e9jx" type="mscore-jump-dc-al-double-coda" func="daCapo" tstamp="0.000000">D.C. al Double Coda</repeatMark>
<repeatMark xml:id="rb0e9jx" type="mscore-jump-dc-al-double-coda" func="daCapo" tstamp="0.000000">D.C. al Codetta</repeatMark>
</measure>
<measure xml:id="m4wju9q" n="26">
<staff xml:id="m26s1" n="1">
Expand All @@ -247,7 +247,7 @@
<mRest xml:id="mdx816j" />
</layer>
</staff>
<repeatMark xml:id="r1rlyijq" type="mscore-jump-ds-al-double-coda" func="dalSegno" tstamp="0.000000">D.S. al Double Coda</repeatMark>
<repeatMark xml:id="r1rlyijq" type="mscore-jump-ds-al-double-coda" func="dalSegno" tstamp="0.000000">D.S. al Codetta</repeatMark>
</measure>
<measure xml:id="m14x5idk" n="29">
<staff xml:id="m29s1" n="1">
Expand Down Expand Up @@ -306,7 +306,7 @@
<mRest xml:id="mnffeub" />
</layer>
</staff>
<repeatMark xml:id="ra4t4wq" type="mscore-jump-dss-al-double-coda" func="dalSegno" tstamp="0.000000">D.S.S. al Double Coda</repeatMark>
<repeatMark xml:id="ra4t4wq" type="mscore-jump-dss-al-double-coda" func="dalSegno" tstamp="0.000000">D.S.S. al Codetta</repeatMark>
</measure>
<measure xml:id="m1cd5cwt" n="37">
<staff xml:id="m37s1" n="1">
Expand Down
6 changes: 3 additions & 3 deletions src/importexport/mei/tests/data/jump-02.mscx
Original file line number Diff line number Diff line change
Expand Up @@ -329,7 +329,7 @@
<Measure>
<Jump>
<style>repeat_right</style>
<text>D.C. al Double Coda</text>
<text>D.C. al Codetta</text>
<jumpTo>start</jumpTo>
<playUntil>varcoda</playUntil>
<continueAt>codab</continueAt>
Expand Down Expand Up @@ -360,7 +360,7 @@
<Measure>
<Jump>
<style>repeat_right</style>
<text>D.S. al Double Coda</text>
<text>D.S. al Codetta</text>
<jumpTo>segno</jumpTo>
<playUntil>varcoda</playUntil>
<continueAt>codab</continueAt>
Expand Down Expand Up @@ -445,7 +445,7 @@
<Measure>
<Jump>
<style>repeat_right</style>
<text>D.S.S. al Double Coda</text>
<text>D.S.S. al Codetta</text>
<jumpTo>varsegno</jumpTo>
<playUntil>varcoda</playUntil>
<continueAt>codab</continueAt>
Expand Down

0 comments on commit d68c996

Please sign in to comment.