fix #289553: expose QProcess to plugin API

musescore · Jun 20, 2019 · dea0a38 · dea0a38
1 parent 1aa445e
commit dea0a38
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/mscore/plugin/api/qmlpluginapi.cpp b/mscore/plugin/api/qmlpluginapi.cpp
@@ -304,7 +304,7 @@ void PluginAPI::registerQmlTypes()
             return;
 
       const char* enumErr = "You can't create an enumeration";
-//TODO-ws            qmlRegisterType<MsProcess>  ("MuseScore", 3, 0, "QProcess");
+      qmlRegisterType<MsProcess>  ("MuseScore", 3, 0, "QProcess");
       qmlRegisterType<FileIO, 1>  ("FileIO",    3, 0, "FileIO");
       //-----------mscore bindings
       qmlRegisterUncreatableMetaObject(Ms::staticMetaObject, "MuseScore", 3, 0, "Ms", enumErr);

diff --git a/mscore/plugin/api/util.h b/mscore/plugin/api/util.h
@@ -104,9 +104,6 @@ class FileIO : public QObject {
       QString mSource;
       };
 
-// These classes usage in plugins is anyway disabled
-// so exclude them from documentation too
-///   \cond MS_INTERNAL
 //---------------------------------------------------------
 //   MsProcess
 //   @@ QProcess
@@ -127,7 +124,10 @@ class MsProcess : public QProcess {
       Q_INVOKABLE QByteArray readAllStandardOutput()      { return QProcess::readAllStandardOutput(); }
       };
 
-//---------------------------------------------------------
+// These classes usage in plugins is anyway disabled
+// so exclude them from documentation too
+///   \cond MS_INTERNAL
+/// //---------------------------------------------------------
 //   @@ ScoreView
 ///    This is an GUI element to show a score.
 //---------------------------------------------------------

diff --git a/share/plugins/run.qml b/share/plugins/run.qml
@@ -27,7 +27,7 @@ import MuseScore 3.0
 MuseScore {
       menuPath: "Plugins.run"
       version:  "3.0"
-      description: "This demo plugin runs an external command. Probably this will only work on Linux."
+      description: "This demo plugin runs an external command."
       requiresScore: false
 
       QProcess {
@@ -36,7 +36,8 @@ MuseScore {
 
       onRun: {
             console.log("run ls");
-            proc.start("/bin/ls");
+            //proc.start("/bin/ls"); // Linux, Mac(?)
+            proc.start("cmd.exe /c dir"); // Windows
             var val = proc.waitForFinished(30000);
             if (val)
                   console.log(proc.readAllStandardOutput());