Skip to content

Commit

Permalink
fix #311353: Playback fix for diminished chords
Browse files Browse the repository at this point in the history
  • Loading branch information
Mystic-Slice committed May 25, 2021
1 parent 7e8ad9b commit f4ba95e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/libmscore/realizedharmony.cpp
Expand Up @@ -424,6 +424,9 @@ RealizedHarmony::PitchMap RealizedHarmony::getIntervals(int rootTpc, bool litera
if (!(omit & (1 << 5))) {
ret.insert(step2pitchInterval(5, -1) + RANK_MULT * RANK_3RD, tpcInterval(rootTpc, 5, -1)); //dim5
}
if (!(omit & (1 << 7)) && quality == "half-diminished") {
ret.insert(step2pitchInterval(7, -1) + RANK_MULT * RANK_7TH, tpcInterval(rootTpc, 7, -1)); //min7
}
alt5 = true;
} else { //major or dominant
if (!(omit & (1 << 3))) {
Expand Down Expand Up @@ -464,6 +467,8 @@ RealizedHarmony::PitchMap RealizedHarmony::getIntervals(int rootTpc, bool litera
ret.insert(11 + RANK_MULT * RANK_7TH, tpcInterval(rootTpc, 7, 0));
} else if (quality == "diminished") {
ret.insert(9 + RANK_MULT * RANK_7TH, tpcInterval(rootTpc, 7, -2));
} else if (quality == "half-diminished") {
// 7th note already added when handling chord quality
} else { //dominant or augmented or minor
ret.insert(10 + RANK_MULT * RANK_7TH, tpcInterval(rootTpc, 7, -1));
}
Expand Down

0 comments on commit f4ba95e

Please sign in to comment.