Skip to content

Commit

Permalink
fix #283111: Add octobass
Browse files Browse the repository at this point in the history
and add some comments to the bowed instruments reg. their sound.
Revealed a wrong pizzicato sound for Baryton (dulcimer), corrected in
the due course
  • Loading branch information
Jojo-Schmitz committed Mar 2, 2020
1 parent 56bb365 commit f84c64d
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 13 deletions.
48 changes: 35 additions & 13 deletions share/instruments/instruments.xml
Original file line number Diff line number Diff line change
Expand Up @@ -10698,13 +10698,13 @@
<aPitchRange>24-108</aPitchRange>
<pPitchRange>24-108</pPitchRange>
<Channel name="arco">
<program value="48"/>
<program value="48"/> <!--String Ensemble 1-->
</Channel>
<Channel name="pizzicato">
<program value="45"/>
<program value="45"/> <!--Pizzicato Strings-->
</Channel>
<Channel name="tremolo">
<program value="44"/>
<program value="44"/> <!--Tremolo Strings-->
</Channel>
</Instrument>
<Instrument id="erhu">
Expand Down Expand Up @@ -10742,13 +10742,13 @@
<aPitchRange>48-79</aPitchRange>
<pPitchRange>48-93</pPitchRange>
<Channel name="arco">
<program value="41"/>
<program value="41"/> <!--Viola-->
</Channel>
<Channel name="pizzicato">
<program value="45"/>
<program value="45"/> <!--Pizzicato Strings-->
</Channel>
<Channel name="tremolo">
<program value="44"/>
<program value="44"/> <!--Tremolo Strings-->
</Channel>
<genre>world</genre>
</Instrument>
Expand Down Expand Up @@ -10852,8 +10852,8 @@
<barlineSpan>1</barlineSpan>
<aPitchRange>36-67</aPitchRange>
<pPitchRange>36-90</pPitchRange>
<Channel name="arco"> <!--Cello-->
<program value="42"/>
<Channel name="arco">
<program value="42"/> <!--Cello-->
</Channel>
<Channel name="pizzicato">
<program value="45"/> <!--Pizzicato Strings-->
Expand Down Expand Up @@ -10901,8 +10901,8 @@
<pPitchRange>24-67</pPitchRange>
<transposeDiatonic>-7</transposeDiatonic>
<transposeChromatic>-12</transposeChromatic>
<Channel name="arco"> <!--Contrabass-->
<program value="43"/>
<Channel name="arco">
<program value="43"/> <!--Contrabass-->
</Channel>
<Channel name="pizzicato">
<program value="32"/> <!--Accoustic Bass-->
Expand Down Expand Up @@ -10946,6 +10946,28 @@
<longName>Double Bass</longName>
<shortName>Db.</shortName>
</Instrument>
<Instrument id="octobass">
<longName>Octobass</longName>
<shortName>Otb.</shortName>
<description>Octobass</description>
<musicXMLid>strings.octobass</musicXMLid>
<transposingClef>F</transposingClef>
<concertClef>F15mb</concertClef>
<barlineSpan>1</barlineSpan>
<aPitchRange>21-31</aPitchRange>
<pPitchRange>12-33</pPitchRange>
<transposeDiatonic>-14</transposeDiatonic>
<transposeChromatic>-24</transposeChromatic>
<Channel name="arco">
<program value="43"/> <!--Contrabass-->
</Channel>
<Channel name="pizzicato">
<program value="32"/> <!--Accoustic Bass-->
</Channel>
<Channel name="tremolo">
<program value="44"/> <!--Tremolo Strings-->
</Channel>
</Instrument>
<Instrument id="pardessus-de-viole">
<longName>Pardessus de viole</longName>
<shortName>Pds. v.</shortName>
Expand Down Expand Up @@ -11112,13 +11134,13 @@
<aPitchRange>33-74</aPitchRange>
<pPitchRange>33-79</pPitchRange>
<Channel name="arco">
<program value="42"/>
<program value="42"/> <!--Cello-->
</Channel>
<Channel name="pizzicato">
<program value="15"/>
<program value="45"/> <!--Pizzicato Strings-->
</Channel>
<Channel name="tremolo">
<program value="44"/>
<program value="44"/> <!--Tremolo Strings-->
</Channel>
<genre>earlymusic</genre>
</Instrument>
Expand Down
5 changes: 5 additions & 0 deletions share/instruments/instrumentsxml.h
Original file line number Diff line number Diff line change
Expand Up @@ -1366,6 +1366,11 @@ QT_TRANSLATE_NOOP("InstrumentsXML", "pizzicato"),
QT_TRANSLATE_NOOP("InstrumentsXML", "tremolo"),
QT_TRANSLATE_NOOP("InstrumentsXML", "Double Bass"),
QT_TRANSLATE_NOOP3("InstrumentsXML", "Db.", "Double Bass"),
QT_TRANSLATE_NOOP("InstrumentsXML", "Octobass"),
QT_TRANSLATE_NOOP3("InstrumentsXML", "Otb.", "Octobass"),
QT_TRANSLATE_NOOP("InstrumentsXML", "arco"),
QT_TRANSLATE_NOOP("InstrumentsXML", "pizzicato"),
QT_TRANSLATE_NOOP("InstrumentsXML", "tremolo"),
QT_TRANSLATE_NOOP("InstrumentsXML", "Pardessus de viole"),
QT_TRANSLATE_NOOP3("InstrumentsXML", "Pds. v.", "Pardessus de viole"),
QT_TRANSLATE_NOOP("InstrumentsXML", "arco"),
Expand Down

0 comments on commit f84c64d

Please sign in to comment.