Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4 Task] Notehead popup design improvements #10028

Closed
bkunda opened this issue Dec 9, 2021 · 9 comments · Fixed by #10975
Closed

[MU4 Task] Notehead popup design improvements #10028

bkunda opened this issue Dec 9, 2021 · 9 comments · Fixed by #10975
Assignees
Labels
P2 Priority: Medium

Comments

@bkunda
Copy link

bkunda commented Dec 9, 2021

[Tasks updated 14 Dec '21]

Task description
This task comprises a few minor UX improvements to the notehead popup in Properties.
Importantly, it reinstates the "small notehead" functionality from MS3.6, which has been accidentally omitted from the MS4 project.

Tasks for implementation are:

  1. Reposition "Hide notehead" checkbox beneath "Notehead type" panel
  2. Implement "Notehead parentheses" toggle buttons (toggling functionality of notehead parentheses palette item)
  3. Reinstate checkbox from MS3.6 (Inspector > Note > Small) and rename label to "Small notehead"
  4. Rename "Dotted note position" label to "Duration note position"

NEW NOTEHEAD POPUP DESIGN_v2

The "small notehead" functionality to be reinstated from MS3.6 (TASK 2) is this:
small-notehead-3 6-2

Link to Figma design file: https://www.figma.com/file/l0TQUrNFZmEfrZnfHhFDfb/Musescore-Notation-App-MASTER?node-id=20835%3A668717

Note also
Issue #9169 includes a bug fix for this panel, as well as a task for disabling the "Duration dot position" buttons depending on what is selected in the score. Please advise if these tasks require further illustration and I'll be happy to supply it.

Let me know if anything is unclear, or if you have any questions!
Thanks 🙂

@bkunda bkunda added the P2 Priority: Medium label Dec 9, 2021
@bkunda bkunda added this to To do in [MU4.0 - INSPECTOR] via automation Dec 9, 2021
@Tantacrul
Copy link
Contributor

Just to point out: this fixes a regression in the Inspector that I missed. It is already possible in MS3.

@cbjeukendrup
Copy link
Contributor

Two remarks:

  • Would it make sense to put the "Hide notehead" and "Small notehead" checkboxes above the "Dotted note position" control? Because those checkboxes are related to the notehead type settings.
  • Would it make sense to rename "Dotted note position" control to "Augmentation dot position"?
    • And to move it to the "Show more" section"?
    • And to hide it for notes that do not have any dots?

@Tantacrul
Copy link
Contributor

I think you're right that dotted note options should probably go under 'hide notehead' / 'small notehead'.

I wouldn't have thought to put them in 'show more' because the options are not quite so niche. But I don't feel very strongly about that.

I agree it should only be enabled when a dotted note head is chosen. I also prefer 'Augmentation dot position' :)

@bkunda
Copy link
Author

bkunda commented Dec 13, 2021

I too agree with the repositioning of the "dotted note position" settings beneath the checkbox options ✅.
And also that this setting should only be available when a dotted note is selected ✅.

Like @Tantacrul, I also don't have a strong opinion about whether this setting should go in "show more" or not. If pressed for a decisive resolution, however, I might be slightly in favour of leaving them where they are (i.e. not in "show more") for these reasons:

  1. I can see there being some not-so-atypical user cases where the dot needs to be manually repositioned, particularly where note clusters are concerned, in which instances MuseScore currently doesn't always render the dots correctly (i.e. dots appear to not be visible against certain notes). Solving this problem by having to click through to a separate properties subsection feels clunky (as it presently does in MS3.6). Exposing these settings more visibly would make the solution to these cases easier to discover.
  2. The current options in "show more" only affect the notehead, and only in ways that solve very esoteric problems. I do think that correcting the position of the dot is less niche than these other options.

Lastly, I would be in favour of labelling this setting "duration dot position". I don't particularly like the word "Augmentation" as it is, at least in my mind, too strongly associated with a harmonic principle, rather than a rhythmic one.

lmk if there is any strong opposition to the above, or other thoughts that we collectively haven't considered. I'd be happy to post an updated design shortly 🙂

@cbjeukendrup
Copy link
Contributor

Ok, I agree, let's keep the "dotted note position" settings visible directly 👍 (at least until MuseScore's automatic placement is always correct).

I'm not completely sure whether I would like "duration dot". I believe that "Augmentation dot" is quite a common name, and sounds slightly more professional to me. But I feel I might not be able to judge about this very well because I'm not a native English speaker, and your point about the possible confusion with harmony is also a very fair one.

@Tantacrul what are your thoughts?

@bkunda
Copy link
Author

bkunda commented Dec 13, 2021

fwiw:

  • SMuFL = "Augmentation dot"
  • Gould = "Duration dot"

I do expect that "augmentation dot" is more common than I'm aware, in which case I'd be happy for it to take this name 🙂

@Tantacrul
Copy link
Contributor

Hmmm. Another of these juicy instances where the generally agreed upon term is vague and technical...

I might just create a poll to find out what people prefer because I think we're damned no matter what choice we make here. The accompanying icons are probably going to have to do the heavy lifting. Setting up the poll now!

@Tantacrul
Copy link
Contributor

@bkunda
Copy link
Author

bkunda commented Dec 14, 2021

The people have spoken! It seems that "Duration dot position" is the preferred label by around 70% of respondents, so in the interests of supporting the greatest understanding, I think we'll go with this.

Design spec has been updated in the task above. Let me know if further info is needed!

@RomanPudashkin RomanPudashkin added this to Needs triage in [MU4.0 ALPHA2] via automation Mar 25, 2022
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Mar 30, 2022
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Mar 30, 2022
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Mar 30, 2022
@vpereverzev vpereverzev moved this from Needs triage to In progress in [MU4.0 ALPHA2] Apr 8, 2022
RomanPudashkin added a commit to RomanPudashkin/MuseScore that referenced this issue Apr 26, 2022
[MU4.0 - INSPECTOR] automation moved this from To do to Done Apr 26, 2022
[MU4.0 ALPHA2] automation moved this from In progress to Closed Apr 26, 2022
RomanPudashkin added a commit that referenced this issue Apr 26, 2022
…ents

[MU4] Fix #10028: Notehead popup design improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Priority: Medium
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

5 participants